Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1317969 > unrolled thread
| Started by | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| First post | 2016-01-26 15:40 +0100 |
| Last post | 2016-01-26 16:40 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-01-26 15:40 +0100
Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 Guenter Roeck <linux@roeck-us.net> - 2016-01-26 16:40 +0100
| From | William Breathitt Gray <vilhelm.gray@gmail.com> |
|---|---|
| Date | 2016-01-26 15:40 +0100 |
| Subject | Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384 |
| Message-ID | <qVcWK-5sj-19@gated-at.bofh.it> |
On 01/25/2016 5:11 PM, Guenter Roeck wrote: >> + dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n", >> + timeout, WATCHDOG_TIMEOUT); > > Multi-line alignment is off by one character. I used tabs to align the lines to 8-character boundaries. Should I add an additional space to align the "timeout" argument with the "dev" argument? William Breathitt Gray
[toc] | [next] | [standalone]
| From | Guenter Roeck <linux@roeck-us.net> |
|---|---|
| Date | 2016-01-26 16:40 +0100 |
| Message-ID | <qVdSO-644-5@gated-at.bofh.it> |
| In reply to | #1317969 |
On 01/26/2016 06:31 AM, William Breathitt Gray wrote:
> On 01/25/2016 5:11 PM, Guenter Roeck wrote:
>>> + dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
>>> + timeout, WATCHDOG_TIMEOUT);
>>
>> Multi-line alignment is off by one character.
>
> I used tabs to align the lines to 8-character boundaries. Should I add
> an additional space to align the "timeout" argument with the "dev"
> argument?
>
Continuation line alignment should be with "(", so, yes, on the same column as "dev".
Thanks,
Guenter
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web