Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1318058

Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384

From Guenter Roeck <linux@roeck-us.net>
Newsgroups linux.kernel
Subject Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384
Date 2016-01-26 16:40 +0100
Message-ID <qVdSO-644-5@gated-at.bofh.it> (permalink)
References <qVcWK-5sj-19@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On 01/26/2016 06:31 AM, William Breathitt Gray wrote:
> On 01/25/2016 5:11 PM, Guenter Roeck wrote:
>>> +		dev_warn(dev, "Invalid timeout (%u seconds), using default (%u seconds)\n",
>>> +			timeout, WATCHDOG_TIMEOUT);
>>
>> Multi-line alignment is off by one character.
>
> I used tabs to align the lines to 8-character boundaries. Should I add
> an additional space to align the "timeout" argument with the "dev"
> argument?
>

Continuation line alignment should be with "(", so, yes, on the same column as "dev".

Thanks,
Guenter

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH v3] watchdog: Add watchdog timer support for the  WinSystems EBC-C384 William Breathitt Gray <vilhelm.gray@gmail.com> - 2016-01-26 15:40 +0100
  Re: [PATCH v3] watchdog: Add watchdog timer support for the  WinSystems EBC-C384 Guenter Roeck <linux@roeck-us.net> - 2016-01-26 16:40 +0100

csiph-web