Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1320681 > unrolled thread
| Started by | Keerthy <j-keerthy@ti.com> |
|---|---|
| First post | 2016-01-28 14:40 +0100 |
| Last post | 2016-02-08 10:50 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH 0/2] gpio: davinci: driver fixes Keerthy <j-keerthy@ti.com> - 2016-01-28 14:40 +0100
[PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy <j-keerthy@ti.com> - 2016-01-28 14:50 +0100
Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-28 15:30 +0100
Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy <a0393675@ti.com> - 2016-02-08 10:50 +0100
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Date | 2016-01-28 14:40 +0100 |
| Subject | [PATCH 0/2] gpio: davinci: driver fixes |
| Message-ID | <qVUXM-43r-27@gated-at.bofh.it> |
The series has couple of for the gpio driver.
Keerthy (1):
gpio: davinci: Add the missing of-node pointer in the
irq_domain_add_legacy function call
Lokesh Vutla (1):
gpio: davinci: Fix the number of controllers allocated
drivers/gpio/gpio-davinci.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
1.9.1
[toc] | [next] | [standalone]
| From | Keerthy <j-keerthy@ti.com> |
|---|---|
| Date | 2016-01-28 14:50 +0100 |
| Subject | [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call |
| Message-ID | <qVV7s-47l-7@gated-at.bofh.it> |
| In reply to | #1320681 |
Currently the first parameter of irq_domain_add_legacy is NULL.
irq_find_host function returns NULL when we do not populate the of_node
and hence irq_of_parse_and_map call fails whenever we want to request a
gpio irq. This fixes the request_irq failures for gpio interrupts.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
drivers/gpio/gpio-davinci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index ec58f42..c889f31 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
return irq;
}
- irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
+ irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
&davinci_gpio_irq_ops,
chips);
if (!irq_domain) {
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-01-28 15:30 +0100 |
| Subject | Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call |
| Message-ID | <qVVKa-4Gz-27@gated-at.bofh.it> |
| In reply to | #1320686 |
On 01/28/2016 03:38 PM, Keerthy wrote:
> Currently the first parameter of irq_domain_add_legacy is NULL.
> irq_find_host function returns NULL when we do not populate the of_node
> and hence irq_of_parse_and_map call fails whenever we want to request a
> gpio irq. This fixes the request_irq failures for gpio interrupts.
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---
> drivers/gpio/gpio-davinci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index ec58f42..c889f31 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
> return irq;
> }
>
> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
> &davinci_gpio_irq_ops,
> chips);
> if (!irq_domain) {
>
--
regards,
-grygorii
[toc] | [prev] | [next] | [standalone]
| From | Keerthy <a0393675@ti.com> |
|---|---|
| Date | 2016-02-08 10:50 +0100 |
| Subject | Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call |
| Message-ID | <qZQCe-3pM-5@gated-at.bofh.it> |
| In reply to | #1320726 |
On Thursday 28 January 2016 07:48 PM, Grygorii Strashko wrote:
> On 01/28/2016 03:38 PM, Keerthy wrote:
>> Currently the first parameter of irq_domain_add_legacy is NULL.
>> irq_find_host function returns NULL when we do not populate the of_node
>> and hence irq_of_parse_and_map call fails whenever we want to request a
>> gpio irq. This fixes the request_irq failures for gpio interrupts.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>
> Reviewed-by: Grygorii Strashko <grygorii.strashko@ti.com>
A gentle ping on this patch. Thanks Grygorii for the review.
>
>> ---
>> drivers/gpio/gpio-davinci.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
>> index ec58f42..c889f31 100644
>> --- a/drivers/gpio/gpio-davinci.c
>> +++ b/drivers/gpio/gpio-davinci.c
>> @@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct
>> platform_device *pdev)
>> return irq;
>> }
>>
>> - irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
>> + irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
>> &davinci_gpio_irq_ops,
>> chips);
>> if (!irq_domain) {
>>
>
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web