Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1320686

[PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call

Show all headers | View raw

Currently the first parameter of irq_domain_add_legacy is NULL.
irq_find_host function returns NULL when we do not populate the of_node
and hence irq_of_parse_and_map call fails whenever we want to request a
gpio irq. This fixes the request_irq failures for gpio interrupts.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 drivers/gpio/gpio-davinci.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index ec58f42..c889f31 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -511,7 +511,7 @@ static int davinci_gpio_irq_setup(struct platform_device *pdev)
 			return irq;
 		}
 
-		irq_domain = irq_domain_add_legacy(NULL, ngpio, irq, 0,
+		irq_domain = irq_domain_add_legacy(dev->of_node, ngpio, irq, 0,
 							&davinci_gpio_irq_ops,
 							chips);
 		if (!irq_domain) {
-- 
1.9.1

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] gpio: davinci: driver fixes  Keerthy <j-keerthy@ti.com> - 2016-01-28 14:40 +0100
  [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the irq_domain_add_legacy function call Keerthy <j-keerthy@ti.com> - 2016-01-28 14:50 +0100
    Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the  irq_domain_add_legacy function call Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-28 15:30 +0100
      Re: [PATCH 1/2] gpio: davinci: Add the missing of-node pointer in the  irq_domain_add_legacy function call Keerthy <a0393675@ti.com> - 2016-02-08 10:50 +0100

csiph-web