Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316852 > unrolled thread
| Started by | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| First post | 2016-01-25 16:50 +0100 |
| Last post | 2016-01-28 00:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
[PATCH] power: APM_EMULATION does not depend on PM Arnd Bergmann <arnd@arndb.de> - 2016-01-25 16:50 +0100
Re: [PATCH] power: APM_EMULATION does not depend on PM "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-28 00:00 +0100
| From | Arnd Bergmann <arnd@arndb.de> |
|---|---|
| Date | 2016-01-25 16:50 +0100 |
| Subject | [PATCH] power: APM_EMULATION does not depend on PM |
| Message-ID | <qURyX-64A-39@gated-at.bofh.it> |
The APM emulation code does multiple things, and some of them depend on PM_SLEEP, while the battery management does not. However, selecting the symbol like SHARPSL_PM does causes a Kconfig warning: warning: (SHARPSL_PM && PMAC_APM_EMU) selects APM_EMULATION which has unmet direct dependencies (PM && SYS_SUPPORTS_APM_EMULATION) From all I can tell, this is completely harmless, and we can simply allow APM_EMULATION to be enabled here, even if PM is not. Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/power/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig index 02e8dfaa1ce2..68d3ebc12601 100644 --- a/kernel/power/Kconfig +++ b/kernel/power/Kconfig @@ -235,7 +235,7 @@ config PM_TRACE_RTC config APM_EMULATION tristate "Advanced Power Management Emulation" - depends on PM && SYS_SUPPORTS_APM_EMULATION + depends on SYS_SUPPORTS_APM_EMULATION help APM is a BIOS specification for saving power using several different techniques. This is mostly useful for battery powered laptops with -- 2.7.0
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-01-28 00:00 +0100 |
| Message-ID | <qVHec-2ip-53@gated-at.bofh.it> |
| In reply to | #1316852 |
On Monday, January 25, 2016 04:48:28 PM Arnd Bergmann wrote: > The APM emulation code does multiple things, and some of them depend on > PM_SLEEP, while the battery management does not. However, selecting > the symbol like SHARPSL_PM does causes a Kconfig warning: > > warning: (SHARPSL_PM && PMAC_APM_EMU) selects APM_EMULATION which has unmet direct dependencies (PM && SYS_SUPPORTS_APM_EMULATION) > > From all I can tell, this is completely harmless, and we can simply allow > APM_EMULATION to be enabled here, even if PM is not. > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied, thanks! Rafael
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web