Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1317098 > unrolled thread
| Started by | Colin King <colin.king@canonical.com> |
|---|---|
| First post | 2016-01-25 18:30 +0100 |
| Last post | 2016-01-25 19:30 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] IB/sysfs: remove unused va_list args Colin King <colin.king@canonical.com> - 2016-01-25 18:30 +0100
Re: [PATCH] IB/sysfs: remove unused va_list args Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-25 18:50 +0100
Re: [PATCH] IB/sysfs: remove unused va_list args "ira.weiny" <ira.weiny@intel.com> - 2016-01-25 19:30 +0100
| From | Colin King <colin.king@canonical.com> |
|---|---|
| Date | 2016-01-25 18:30 +0100 |
| Subject | [PATCH] IB/sysfs: remove unused va_list args |
| Message-ID | <qUT7I-7lX-9@gated-at.bofh.it> |
From: Colin Ian King <colin.king@canonical.com>
_show_port_gid_attr performs a va_end on some unused va_list args.
Clean this up by removing the args completely.
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/infiniband/core/sysfs.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
index 3de9351..ec46386 100644
--- a/drivers/infiniband/core/sysfs.c
+++ b/drivers/infiniband/core/sysfs.c
@@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
union ib_gid gid;
struct ib_gid_attr gid_attr = {};
ssize_t ret;
- va_list args;
ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
&gid_attr);
@@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
err:
if (gid_attr.ndev)
dev_put(gid_attr.ndev);
- va_end(args);
return ret;
}
--
1.9.1
[toc] | [next] | [standalone]
| From | Jason Gunthorpe <jgunthorpe@obsidianresearch.com> |
|---|---|
| Date | 2016-01-25 18:50 +0100 |
| Message-ID | <qUTr4-7vm-13@gated-at.bofh.it> |
| In reply to | #1317098 |
On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > _show_port_gid_attr performs a va_end on some unused va_list args. > Clean this up by removing the args completely. > > Signed-off-by: Colin Ian King <colin.king@canonical.com> Yep. This is bad new breakage too. Care to add a fixes line? Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com> Jason
[toc] | [prev] | [next] | [standalone]
| From | "ira.weiny" <ira.weiny@intel.com> |
|---|---|
| Date | 2016-01-25 19:30 +0100 |
| Message-ID | <qUU3N-830-39@gated-at.bofh.it> |
| In reply to | #1317098 |
On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Ira Weiny <ira.weiny@intel.com>
> ---
> drivers/infiniband/core/sysfs.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> union ib_gid gid;
> struct ib_gid_attr gid_attr = {};
> ssize_t ret;
> - va_list args;
>
> ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
> &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
> err:
> if (gid_attr.ndev)
> dev_put(gid_attr.ndev);
> - va_end(args);
> return ret;
> }
>
> --
> 1.9.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web