Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317146

Re: [PATCH] IB/sysfs: remove unused va_list args

Show all headers | View raw

On Mon, Jan 25, 2016 at 05:23:47PM +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
> 
> _show_port_gid_attr performs a va_end on some unused va_list args.
> Clean this up by removing the args completely.
> 
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Reviewed-by: Ira Weiny <ira.weiny@intel.com>

> ---
>  drivers/infiniband/core/sysfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/infiniband/core/sysfs.c b/drivers/infiniband/core/sysfs.c
> index 3de9351..ec46386 100644
> --- a/drivers/infiniband/core/sysfs.c
> +++ b/drivers/infiniband/core/sysfs.c
> @@ -336,7 +336,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  	union ib_gid gid;
>  	struct ib_gid_attr gid_attr = {};
>  	ssize_t ret;
> -	va_list args;
>  
>  	ret = ib_query_gid(p->ibdev, p->port_num, tab_attr->index, &gid,
>  			   &gid_attr);
> @@ -348,7 +347,6 @@ static ssize_t _show_port_gid_attr(struct ib_port *p,
>  err:
>  	if (gid_attr.ndev)
>  		dev_put(gid_attr.ndev);
> -	va_end(args);
>  	return ret;
>  }
>  
> -- 
> 1.9.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] IB/sysfs: remove unused va_list args Colin King <colin.king@canonical.com> - 2016-01-25 18:30 +0100
  Re: [PATCH] IB/sysfs: remove unused va_list args Jason Gunthorpe <jgunthorpe@obsidianresearch.com> - 2016-01-25 18:50 +0100
  Re: [PATCH] IB/sysfs: remove unused va_list args "ira.weiny" <ira.weiny@intel.com> - 2016-01-25 19:30 +0100

csiph-web