Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1317012 > unrolled thread

[PATCH] crypto: hash - select CRYPTO_HASH where needed

Back to article view | Back to linux.kernel

Contents

  [PATCH] crypto: hash - select CRYPTO_HASH where needed Arnd Bergmann <arnd@arndb.de> - 2016-01-25 18:00 +0100
    Re: [PATCH] crypto: hash - select CRYPTO_HASH where needed Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 15:50 +0100

#1317012 — [PATCH] crypto: hash - select CRYPTO_HASH where needed

The ghash and poly1305 hash implementations can be enabled when
CONFIG_CRYPTO_HASH is turned off, causing a link error:

crypto/built-in.o: In function `ghash_mod_init':
(.init.text+0xd0): undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `ghash_mod_exit':
(.exit.text+0xb4): undefined reference to `crypto_unregister_shash'
crypto/built-in.o: In function `poly1305_mod_init':
(.init.text+0xb4): undefined reference to `crypto_register_shash'
crypto/built-in.o: In function `poly1305_mod_exit':
(.exit.text+0x98): undefined reference to `crypto_unregister_shash'

This adds an explicit 'select', like all other hashes have it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 crypto/Kconfig | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/crypto/Kconfig b/crypto/Kconfig
index 99109b93604a..2d76676a1253 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -472,11 +472,13 @@ config CRYPTO_CRCT10DIF_PCLMUL
 config CRYPTO_GHASH
 	tristate "GHASH digest algorithm"
 	select CRYPTO_GF128MUL
+	select CRYPTO_HASH
 	help
 	  GHASH is message digest algorithm for GCM (Galois/Counter Mode).
 
 config CRYPTO_POLY1305
 	tristate "Poly1305 authenticator algorithm"
+	select CRYPTO_HASH
 	help
 	  Poly1305 authenticator algorithm, RFC7539.
 
-- 
2.7.0

[toc] | [next] | [standalone]

#1317995

On Mon, Jan 25, 2016 at 05:51:21PM +0100, Arnd Bergmann wrote:
> The ghash and poly1305 hash implementations can be enabled when
> CONFIG_CRYPTO_HASH is turned off, causing a link error:
> 
> crypto/built-in.o: In function `ghash_mod_init':
> (.init.text+0xd0): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `ghash_mod_exit':
> (.exit.text+0xb4): undefined reference to `crypto_unregister_shash'
> crypto/built-in.o: In function `poly1305_mod_init':
> (.init.text+0xb4): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `poly1305_mod_exit':
> (.exit.text+0x98): undefined reference to `crypto_unregister_shash'
> 
> This adds an explicit 'select', like all other hashes have it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web