Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1317995

Re: [PATCH] crypto: hash - select CRYPTO_HASH where needed

From Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups linux.kernel
Subject Re: [PATCH] crypto: hash - select CRYPTO_HASH where needed
Date 2016-01-26 15:50 +0100
Message-ID <qVd6q-5vL-21@gated-at.bofh.it> (permalink)
References <qUSEG-6QD-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Mon, Jan 25, 2016 at 05:51:21PM +0100, Arnd Bergmann wrote:
> The ghash and poly1305 hash implementations can be enabled when
> CONFIG_CRYPTO_HASH is turned off, causing a link error:
> 
> crypto/built-in.o: In function `ghash_mod_init':
> (.init.text+0xd0): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `ghash_mod_exit':
> (.exit.text+0xb4): undefined reference to `crypto_unregister_shash'
> crypto/built-in.o: In function `poly1305_mod_init':
> (.init.text+0xb4): undefined reference to `crypto_register_shash'
> crypto/built-in.o: In function `poly1305_mod_exit':
> (.exit.text+0x98): undefined reference to `crypto_unregister_shash'
> 
> This adds an explicit 'select', like all other hashes have it.
> 
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread


Thread

[PATCH] crypto: hash - select CRYPTO_HASH where needed Arnd Bergmann <arnd@arndb.de> - 2016-01-25 18:00 +0100
  Re: [PATCH] crypto: hash - select CRYPTO_HASH where needed Herbert Xu <herbert@gondor.apana.org.au> - 2016-01-26 15:50 +0100

csiph-web