Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316489 > unrolled thread
| Started by | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| First post | 2016-01-25 12:20 +0100 |
| Last post | 2016-01-25 12:20 +0100 |
| Articles | 1 — 1 participant |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Peter Zijlstra <peterz@infradead.org> - 2016-01-25 12:20 +0100
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Date | 2016-01-25 12:20 +0100 |
| Subject | Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism |
| Message-ID | <qUNlD-33Y-5@gated-at.bofh.it> |
On Mon, Jan 25, 2016 at 04:32:03PM +0800, Huang Rui wrote:
> +struct power_pmu {
> + raw_spinlock_t lock;
> + struct list_head active_list;
Maybe a dumb question, but what is that list for?
You only ever add/del events to/from it, you never iterate it. So why
keep it?
If you drop the list, the lock can go too I think, making all this stuff
simpler.
Back to top | Article view | linux.kernel
csiph-web