Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316489
| From | Peter Zijlstra <peterz@infradead.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism |
| Date | 2016-01-25 12:20 +0100 |
| Message-ID | <qUNlD-33Y-5@gated-at.bofh.it> (permalink) |
| References | <qUNlD-33Y-7@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 25, 2016 at 04:32:03PM +0800, Huang Rui wrote:
> +struct power_pmu {
> + raw_spinlock_t lock;
> + struct list_head active_list;
Maybe a dumb question, but what is that list for?
You only ever add/del events to/from it, you never iterate it. So why
keep it?
If you drop the list, the lock can go too I think, making all this stuff
simpler.
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
Re: [PATCH v3] perf/x86/amd/power: Add AMD accumulated power reporting mechanism Peter Zijlstra <peterz@infradead.org> - 2016-01-25 12:20 +0100
csiph-web