Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316491 > unrolled thread
| Started by | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| First post | 2016-01-25 12:20 +0100 |
| Last post | 2016-01-25 16:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-25 12:20 +0100
Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Chris Wilson <chris@chris-wilson.co.uk> - 2016-01-25 12:30 +0100
[PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-25 12:50 +0100
Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Daniel Vetter <daniel@ffwll.ch> - 2016-01-25 16:40 +0100
| From | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| Date | 2016-01-25 12:20 +0100 |
| Subject | [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig |
| Message-ID | <qUNlE-33Y-11@gated-at.bofh.it> |
Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig
dependency") removed the option STOP_MACHINE from init/Kconfig, but
missed a select to this option from the DRM_I915 option.
Remove this now obsolete select statement.
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
---
drivers/gpu/drm/i915/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index fcd77b2..051eab3 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -10,7 +10,6 @@ config DRM_I915
# the shmem_readpage() which depends upon tmpfs
select SHMEM
select TMPFS
- select STOP_MACHINE
select DRM_KMS_HELPER
select DRM_PANEL
select DRM_MIPI_DSI
--
1.9.1
[toc] | [next] | [standalone]
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Date | 2016-01-25 12:30 +0100 |
| Subject | Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig |
| Message-ID | <qUNvk-37P-13@gated-at.bofh.it> |
| In reply to | #1316491 |
On Mon, Jan 25, 2016 at 12:14:41PM +0100, Andreas Ziegler wrote:
> Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig
> dependency") removed the option STOP_MACHINE from init/Kconfig, but
> missed a select to this option from the DRM_I915 option.
The select didn't exist on the branch on which the patch was applied, so
it couldn't remove it.
Commit 5bab6f60cb4 ("drm/i915: Serialise updates to GGTT with access
through GGTT on Braswel") depended upon a working stop_machine() and so
forced its selection. However, commit 86fffe4a61dd ("kernel: remove
stop_machine() Kconfig dependency") removed the option STOP_MACHINE from
init/Kconfig and ensured that stop_machine() universally works.
Remove this now obsolete select statement.
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
With a little bit of story correction,
Revieweed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
[toc] | [prev] | [next] | [standalone]
| From | Andreas Ziegler <andreas.ziegler@fau.de> |
|---|---|
| Date | 2016-01-25 12:50 +0100 |
| Subject | [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig |
| Message-ID | <qUNOG-3ga-11@gated-at.bofh.it> |
| In reply to | #1316506 |
Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access
through GGTT on Braswell") depended upon a working stop_machine() and
so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd
("kernel: remove stop_machine() Kconfig dependency") removed the option
STOP_MACHINE from init/Kconfig and ensured that stop_machine()
universally works. Due to the order in which the patches were applied,
removing the select from DRM_I915 got lost during merging.
Remove the now obsolete select statement.
Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
---
Changes to v1:
- Tell the story right, suggested by Chris Wilson
drivers/gpu/drm/i915/Kconfig | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
index fcd77b2..051eab3 100644
--- a/drivers/gpu/drm/i915/Kconfig
+++ b/drivers/gpu/drm/i915/Kconfig
@@ -10,7 +10,6 @@ config DRM_I915
# the shmem_readpage() which depends upon tmpfs
select SHMEM
select TMPFS
- select STOP_MACHINE
select DRM_KMS_HELPER
select DRM_PANEL
select DRM_MIPI_DSI
--
1.9.1
[toc] | [prev] | [next] | [standalone]
| From | Daniel Vetter <daniel@ffwll.ch> |
|---|---|
| Date | 2016-01-25 16:40 +0100 |
| Subject | Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig |
| Message-ID | <qURph-60C-25@gated-at.bofh.it> |
| In reply to | #1316535 |
On Mon, Jan 25, 2016 at 12:41:19PM +0100, Andreas Ziegler wrote:
> Commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with access
> through GGTT on Braswell") depended upon a working stop_machine() and
> so forced the selection of STOP_MACHINE. However, commit 86fffe4a61dd
> ("kernel: remove stop_machine() Kconfig dependency") removed the option
> STOP_MACHINE from init/Kconfig and ensured that stop_machine()
> universally works. Due to the order in which the patches were applied,
> removing the select from DRM_I915 got lost during merging.
>
> Remove the now obsolete select statement.
>
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
Applied, thanks.
-Daniel
> ---
> Changes to v1:
> - Tell the story right, suggested by Chris Wilson
>
> drivers/gpu/drm/i915/Kconfig | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/Kconfig b/drivers/gpu/drm/i915/Kconfig
> index fcd77b2..051eab3 100644
> --- a/drivers/gpu/drm/i915/Kconfig
> +++ b/drivers/gpu/drm/i915/Kconfig
> @@ -10,7 +10,6 @@ config DRM_I915
> # the shmem_readpage() which depends upon tmpfs
> select SHMEM
> select TMPFS
> - select STOP_MACHINE
> select DRM_KMS_HELPER
> select DRM_PANEL
> select DRM_MIPI_DSI
> --
> 1.9.1
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web