Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1316506
| From | Chris Wilson <chris@chris-wilson.co.uk> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig |
| Date | 2016-01-25 12:30 +0100 |
| Message-ID | <qUNvk-37P-13@gated-at.bofh.it> (permalink) |
| References | <qUNlE-33Y-11@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Mon, Jan 25, 2016 at 12:14:41PM +0100, Andreas Ziegler wrote:
> Commit 86fffe4a61dd ("kernel: remove stop_machine() Kconfig
> dependency") removed the option STOP_MACHINE from init/Kconfig, but
> missed a select to this option from the DRM_I915 option.
The select didn't exist on the branch on which the patch was applied, so
it couldn't remove it.
Commit 5bab6f60cb4 ("drm/i915: Serialise updates to GGTT with access
through GGTT on Braswel") depended upon a working stop_machine() and so
forced its selection. However, commit 86fffe4a61dd ("kernel: remove
stop_machine() Kconfig dependency") removed the option STOP_MACHINE from
init/Kconfig and ensured that stop_machine() universally works.
Remove this now obsolete select statement.
> Signed-off-by: Andreas Ziegler <andreas.ziegler@fau.de>
With a little bit of story correction,
Revieweed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-25 12:20 +0100
Re: [PATCH] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Chris Wilson <chris@chris-wilson.co.uk> - 2016-01-25 12:30 +0100
[PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Andreas Ziegler <andreas.ziegler@fau.de> - 2016-01-25 12:50 +0100
Re: [PATCH v2] drm/i915: Remove select to deleted STOP_MACHINE from Kconfig Daniel Vetter <daniel@ffwll.ch> - 2016-01-25 16:40 +0100
csiph-web