Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1315682 > unrolled thread

[PATCH] reset: hisilicon: check return value of reset_controller_register()

Started byMasahiro Yamada <yamada.masahiro@socionext.com>
First post2016-01-23 17:30 +0100
Last post2016-01-25 11:10 +0100
Articles 2 — 2 participants

Back to article view | Back to linux.kernel


Contents

  [PATCH] reset: hisilicon: check return value of reset_controller_register() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-23 17:30 +0100
    Re: [PATCH] reset: hisilicon: check return value of  reset_controller_register() Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-25 11:10 +0100

#1315682 — [PATCH] reset: hisilicon: check return value of reset_controller_register()

FromMasahiro Yamada <yamada.masahiro@socionext.com>
Date2016-01-23 17:30 +0100
Subject[PATCH] reset: hisilicon: check return value of reset_controller_register()
Message-ID<qU9ez-5ik-23@gated-at.bofh.it>
The newly added hisilicon reset driver missed the subsystem-wide
fixup by commit d1f15aa09558 ("reset: check return value of
reset_controller_register()").  So fix it now.

Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
---

 drivers/reset/hisilicon/hi6220_reset.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
index 7787a9b..744b2e7 100644
--- a/drivers/reset/hisilicon/hi6220_reset.c
+++ b/drivers/reset/hisilicon/hi6220_reset.c
@@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev)
 	data->rc_dev.ops = &hi6220_reset_ops;
 	data->rc_dev.of_node = pdev->dev.of_node;
 
-	reset_controller_register(&data->rc_dev);
-
-	return 0;
+	return reset_controller_register(&data->rc_dev);
 }
 
 static const struct of_device_id hi6220_reset_match[] = {
-- 
1.9.1

[toc] | [next] | [standalone]


#1316394 — Re: [PATCH] reset: hisilicon: check return value of reset_controller_register()

FromPhilipp Zabel <p.zabel@pengutronix.de>
Date2016-01-25 11:10 +0100
SubjectRe: [PATCH] reset: hisilicon: check return value of reset_controller_register()
Message-ID<qUMfW-2lm-37@gated-at.bofh.it>
In reply to#1315682
Am Sonntag, den 24.01.2016, 01:19 +0900 schrieb Masahiro Yamada:
> The newly added hisilicon reset driver missed the subsystem-wide
> fixup by commit d1f15aa09558 ("reset: check return value of
> reset_controller_register()").  So fix it now.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/reset/hisilicon/hi6220_reset.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 7787a9b..744b2e7 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev)
>  	data->rc_dev.ops = &hi6220_reset_ops;
>  	data->rc_dev.of_node = pdev->dev.of_node;
>  
> -	reset_controller_register(&data->rc_dev);
> -
> -	return 0;
> +	return reset_controller_register(&data->rc_dev);
>  }
>  
>  static const struct of_device_id hi6220_reset_match[] = {

Applied, thanks.

regards
Philipp

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web