Re: [PATCH] reset: hisilicon: check return value of reset_controller_register()

From	Philipp Zabel <p.zabel@pengutronix.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] reset: hisilicon: check return value of reset_controller_register()
Date	2016-01-25 11:10 +0100
Message-ID	<qUMfW-2lm-37@gated-at.bofh.it> (permalink)
References	<qU9ez-5ik-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Am Sonntag, den 24.01.2016, 01:19 +0900 schrieb Masahiro Yamada:
> The newly added hisilicon reset driver missed the subsystem-wide
> fixup by commit d1f15aa09558 ("reset: check return value of
> reset_controller_register()").  So fix it now.
> 
> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com>
> ---
> 
>  drivers/reset/hisilicon/hi6220_reset.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/reset/hisilicon/hi6220_reset.c b/drivers/reset/hisilicon/hi6220_reset.c
> index 7787a9b..744b2e7 100644
> --- a/drivers/reset/hisilicon/hi6220_reset.c
> +++ b/drivers/reset/hisilicon/hi6220_reset.c
> @@ -83,9 +83,7 @@ static int hi6220_reset_probe(struct platform_device *pdev)
>  	data->rc_dev.ops = &hi6220_reset_ops;
>  	data->rc_dev.of_node = pdev->dev.of_node;
>  
> -	reset_controller_register(&data->rc_dev);
> -
> -	return 0;
> +	return reset_controller_register(&data->rc_dev);
>  }
>  
>  static const struct of_device_id hi6220_reset_match[] = {

Applied, thanks.

regards
Philipp

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] reset: hisilicon: check return value of reset_controller_register() Masahiro Yamada <yamada.masahiro@socionext.com> - 2016-01-23 17:30 +0100
  Re: [PATCH] reset: hisilicon: check return value of  reset_controller_register() Philipp Zabel <p.zabel@pengutronix.de> - 2016-01-25 11:10 +0100

csiph-web