Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316153 > unrolled thread

[PATCH] mmc: dw_mmc: remove repetitive clear interrupt

Started byShawn Lin <shawn.lin@rock-chips.com>
First post2016-01-25 02:20 +0100
Last post2016-01-26 01:50 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-25 02:20 +0100
    Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-25 05:20 +0100
      Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-25 06:00 +0100
        Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Arnd Bergmann <arnd@arndb.de> - 2016-01-25 10:00 +0100
          Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-26 01:50 +0100

#1316153 — [PATCH] mmc: dw_mmc: remove repetitive clear interrupt

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-01-25 02:20 +0100
Subject[PATCH] mmc: dw_mmc: remove repetitive clear interrupt
Message-ID<qUDZ0-4LE-5@gated-at.bofh.it>
This patch remove repetitive clear interrupt while
probing dw_mmc.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
---

 drivers/mmc/host/dw_mmc.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
index 7128351..1991872 100644
--- a/drivers/mmc/host/dw_mmc.c
+++ b/drivers/mmc/host/dw_mmc.c
@@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
 	 * Enable interrupts for command done, data over, data empty,
 	 * receive ready and error such as transmit, receive timeout, crc error
 	 */
-	mci_writel(host, RINTSTS, 0xFFFFFFFF);
 	mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
 		   SDMMC_INT_TXDR | SDMMC_INT_RXDR |
 		   DW_MCI_ERROR_FLAGS);
-- 
2.3.7

[toc] | [next] | [standalone]

#1316196

FromJaehoon Chung <jh80.chung@samsung.com>
Date2016-01-25 05:20 +0100
Message-ID<qUGNb-6Mh-3@gated-at.bofh.it>
In reply to#1316153
Hi, Shawn.

On 01/25/2016 10:13 AM, Shawn Lin wrote:
> This patch remove repetitive clear interrupt while
> probing dw_mmc.

Could you explain to me more?

Best Regards,
Jaehoon Chung

> 
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
> ---
> 
>  drivers/mmc/host/dw_mmc.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
> index 7128351..1991872 100644
> --- a/drivers/mmc/host/dw_mmc.c
> +++ b/drivers/mmc/host/dw_mmc.c
> @@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
>  	 * Enable interrupts for command done, data over, data empty,
>  	 * receive ready and error such as transmit, receive timeout, crc error
>  	 */
> -	mci_writel(host, RINTSTS, 0xFFFFFFFF);
>  	mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
>  		   SDMMC_INT_TXDR | SDMMC_INT_RXDR |
>  		   DW_MCI_ERROR_FLAGS);
>

[toc] | [prev] | [next] | [standalone]

#1316206

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-01-25 06:00 +0100
Message-ID<qUHpU-754-11@gated-at.bofh.it>
In reply to#1316196
On 2016/1/25 12:14, Jaehoon Chung wrote:
> Hi, Shawn.
>
> On 01/25/2016 10:13 AM, Shawn Lin wrote:
>> This patch remove repetitive clear interrupt while
>> probing dw_mmc.
>
> Could you explain to me more?

yes, it's a trivial improvement.

dw_mci_probe clear interrupt and disable all interrupt firstly.
Then commit 2da1d7f2 add a new clear-interrupt operation before
enable some interrupt. I can't see any reason to clear it twice
here. No any side effect I had found in my test pattern without this
. May I miss some important case?
>
> Best Regards,
> Jaehoon Chung
>
>>
>> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
>> ---
>>
>>   drivers/mmc/host/dw_mmc.c | 1 -
>>   1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c
>> index 7128351..1991872 100644
>> --- a/drivers/mmc/host/dw_mmc.c
>> +++ b/drivers/mmc/host/dw_mmc.c
>> @@ -3117,7 +3117,6 @@ int dw_mci_probe(struct dw_mci *host)
>>   	 * Enable interrupts for command done, data over, data empty,
>>   	 * receive ready and error such as transmit, receive timeout, crc error
>>   	 */
>> -	mci_writel(host, RINTSTS, 0xFFFFFFFF);
>>   	mci_writel(host, INTMASK, SDMMC_INT_CMD_DONE | SDMMC_INT_DATA_OVER |
>>   		   SDMMC_INT_TXDR | SDMMC_INT_RXDR |
>>   		   DW_MCI_ERROR_FLAGS);
>>
>
>
>
>


-- 
Best Regards
Shawn Lin

[toc] | [prev] | [next] | [standalone]

#1316296

FromArnd Bergmann <arnd@arndb.de>
Date2016-01-25 10:00 +0100
Message-ID<qULaa-1mV-3@gated-at.bofh.it>
In reply to#1316206
On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
> On 2016/1/25 12:14, Jaehoon Chung wrote:
> > Hi, Shawn.
> >
> > On 01/25/2016 10:13 AM, Shawn Lin wrote:
> >> This patch remove repetitive clear interrupt while
> >> probing dw_mmc.
> >
> > Could you explain to me more?
> 
> yes, it's a trivial improvement.
> 
> dw_mci_probe clear interrupt and disable all interrupt firstly.
> Then commit 2da1d7f2 add a new clear-interrupt operation before
> enable some interrupt. I can't see any reason to clear it twice
> here. No any side effect I had found in my test pattern without this
> . May I miss some important case?
> 

The explanation should go into the patch description to explain why
it is done. The one sentence "This patch remove repetitive clear
interrupt while probing dw_mmc" that you wrote instead can be
removed, it just repeats the patch subject.

	Arnd

[toc] | [prev] | [next] | [standalone]

#1317433

FromShawn Lin <shawn.lin@rock-chips.com>
Date2016-01-26 01:50 +0100
Message-ID<qUZZx-3Gr-21@gated-at.bofh.it>
In reply to#1316296
On 2016/1/25 16:55, Arnd Bergmann wrote:
> On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
>> On 2016/1/25 12:14, Jaehoon Chung wrote:
>>> Hi, Shawn.
>>>
>>> On 01/25/2016 10:13 AM, Shawn Lin wrote:
>>>> This patch remove repetitive clear interrupt while
>>>> probing dw_mmc.
>>>
>>> Could you explain to me more?
>>
>> yes, it's a trivial improvement.
>>
>> dw_mci_probe clear interrupt and disable all interrupt firstly.
>> Then commit 2da1d7f2 add a new clear-interrupt operation before
>> enable some interrupt. I can't see any reason to clear it twice
>> here. No any side effect I had found in my test pattern without this
>> . May I miss some important case?
>>
>
> The explanation should go into the patch description to explain why
> it is done. The one sentence "This patch remove repetitive clear
> interrupt while probing dw_mmc" that you wrote instead can be
> removed, it just repeats the patch subject.
>

Hi Arnd

Thanks for sharing that. I will respin v2 to add this into commit-msg.

> 	Arnd
>
>
>


-- 
Best Regards
Shawn Lin

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web