Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1316296

Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt

Show all headers | View raw

On Monday 25 January 2016 12:56:25 Shawn Lin wrote:
> On 2016/1/25 12:14, Jaehoon Chung wrote:
> > Hi, Shawn.
> >
> > On 01/25/2016 10:13 AM, Shawn Lin wrote:
> >> This patch remove repetitive clear interrupt while
> >> probing dw_mmc.
> >
> > Could you explain to me more?
> 
> yes, it's a trivial improvement.
> 
> dw_mci_probe clear interrupt and disable all interrupt firstly.
> Then commit 2da1d7f2 add a new clear-interrupt operation before
> enable some interrupt. I can't see any reason to clear it twice
> here. No any side effect I had found in my test pattern without this
> . May I miss some important case?
> 

The explanation should go into the patch description to explain why
it is done. The one sentence "This patch remove repetitive clear
interrupt while probing dw_mmc" that you wrote instead can be
removed, it just repeats the patch subject.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-25 02:20 +0100
  Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Jaehoon Chung <jh80.chung@samsung.com> - 2016-01-25 05:20 +0100
    Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-25 06:00 +0100
      Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Arnd Bergmann <arnd@arndb.de> - 2016-01-25 10:00 +0100
        Re: [PATCH] mmc: dw_mmc: remove repetitive clear interrupt Shawn Lin <shawn.lin@rock-chips.com> - 2016-01-26 01:50 +0100

csiph-web