Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1314133 > unrolled thread
| Started by | Gustavo Padovan <gustavo@padovan.org> |
|---|---|
| First post | 2016-01-21 12:50 +0100 |
| Last post | 2016-01-21 21:40 +0100 |
| Articles | 4 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Gustavo Padovan <gustavo@padovan.org> - 2016-01-21 12:50 +0100
Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Greg KH <gregkh@linuxfoundation.org> - 2016-01-21 21:00 +0100
Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-01-21 21:10 +0100
Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Greg KH <gregkh@linuxfoundation.org> - 2016-01-21 21:40 +0100
| From | Gustavo Padovan <gustavo@padovan.org> |
|---|---|
| Date | 2016-01-21 12:50 +0100 |
| Subject | [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on |
| Message-ID | <qTlUu-4G5-15@gated-at.bofh.it> |
From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> timeline was wrongly assigned with ->get_driver_name(). Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> --- include/trace/events/fence.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h index 98feb1b..d6dfa05 100644 --- a/include/trace/events/fence.h +++ b/include/trace/events/fence.h @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on, TP_STRUCT__entry( __string(driver, fence->ops->get_driver_name(fence)) - __string(timeline, fence->ops->get_driver_name(fence)) + __string(timeline, fence->ops->get_timeline_name(fence)) __field(unsigned int, context) __field(unsigned int, seqno) -- 2.5.0
[toc] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-01-21 21:00 +0100 |
| Subject | Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on |
| Message-ID | <qTtyF-1tD-5@gated-at.bofh.it> |
| In reply to | #1314133 |
On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > timeline was wrongly assigned with ->get_driver_name(). > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > --- > include/trace/events/fence.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h > index 98feb1b..d6dfa05 100644 > --- a/include/trace/events/fence.h > +++ b/include/trace/events/fence.h > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on, > > TP_STRUCT__entry( > __string(driver, fence->ops->get_driver_name(fence)) > - __string(timeline, fence->ops->get_driver_name(fence)) > + __string(timeline, fence->ops->get_timeline_name(fence)) > __field(unsigned int, context) > __field(unsigned int, seqno) Why would you send this to: me? I am not the trace maintainer...
[toc] | [prev] | [next] | [standalone]
| From | Gustavo Padovan <gustavo.padovan@collabora.co.uk> |
|---|---|
| Date | 2016-01-21 21:10 +0100 |
| Subject | Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on |
| Message-ID | <qTtIm-1Np-7@gated-at.bofh.it> |
| In reply to | #1314471 |
2016-01-21 Greg KH <gregkh@linuxfoundation.org>: > On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote: > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > > timeline was wrongly assigned with ->get_driver_name(). > > > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > --- > > include/trace/events/fence.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h > > index 98feb1b..d6dfa05 100644 > > --- a/include/trace/events/fence.h > > +++ b/include/trace/events/fence.h > > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on, > > > > TP_STRUCT__entry( > > __string(driver, fence->ops->get_driver_name(fence)) > > - __string(timeline, fence->ops->get_driver_name(fence)) > > + __string(timeline, fence->ops->get_timeline_name(fence)) > > __field(unsigned int, context) > > __field(unsigned int, seqno) > > Why would you send this to: me? I am not the trace maintainer... Because you are the original committer of the file. But this should have been addressed to the trace maintainer. Gustavo
[toc] | [prev] | [next] | [standalone]
| From | Greg KH <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-01-21 21:40 +0100 |
| Subject | Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on |
| Message-ID | <qTubp-1Zs-31@gated-at.bofh.it> |
| In reply to | #1314478 |
On Thu, Jan 21, 2016 at 06:09:05PM -0200, Gustavo Padovan wrote: > 2016-01-21 Greg KH <gregkh@linuxfoundation.org>: > > > On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote: > > > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > > > > timeline was wrongly assigned with ->get_driver_name(). > > > > > > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk> > > > --- > > > include/trace/events/fence.h | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h > > > index 98feb1b..d6dfa05 100644 > > > --- a/include/trace/events/fence.h > > > +++ b/include/trace/events/fence.h > > > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on, > > > > > > TP_STRUCT__entry( > > > __string(driver, fence->ops->get_driver_name(fence)) > > > - __string(timeline, fence->ops->get_driver_name(fence)) > > > + __string(timeline, fence->ops->get_timeline_name(fence)) > > > __field(unsigned int, context) > > > __field(unsigned int, seqno) > > > > Why would you send this to: me? I am not the trace maintainer... > > Because you are the original committer of the file. I did? I have committed lots of files/patches that I am not the owner/maintainer of. > But this should have been addressed to the trace maintainer. scripts/get_maintainer.pl is your friend, please use it :) thanks, greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web