Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1314478

Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on

From Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Newsgroups linux.kernel
Subject Re: [PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on
Date 2016-01-21 21:10 +0100
Message-ID <qTtIm-1Np-7@gated-at.bofh.it> (permalink)
References <qTlUu-4G5-15@gated-at.bofh.it> <qTtyF-1tD-5@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


2016-01-21 Greg KH <gregkh@linuxfoundation.org>:

> On Thu, Jan 21, 2016 at 09:48:14AM -0200, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > 
> > timeline was wrongly assigned with ->get_driver_name().
> > 
> > Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> > ---
> >  include/trace/events/fence.h | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/include/trace/events/fence.h b/include/trace/events/fence.h
> > index 98feb1b..d6dfa05 100644
> > --- a/include/trace/events/fence.h
> > +++ b/include/trace/events/fence.h
> > @@ -17,7 +17,7 @@ TRACE_EVENT(fence_annotate_wait_on,
> >  
> >  	TP_STRUCT__entry(
> >  		__string(driver, fence->ops->get_driver_name(fence))
> > -		__string(timeline, fence->ops->get_driver_name(fence))
> > +		__string(timeline, fence->ops->get_timeline_name(fence))
> >  		__field(unsigned int, context)
> >  		__field(unsigned int, seqno)
> 
> Why would you send this to: me?  I am not the trace maintainer...

Because you are the original committer of the file. But this should have
been addressed to the trace maintainer.

	Gustavo

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] dma-buf/fence: fix timeline str value on fence_annotate_wait_on Gustavo Padovan <gustavo@padovan.org> - 2016-01-21 12:50 +0100
  Re: [PATCH] dma-buf/fence: fix timeline str value on  fence_annotate_wait_on Greg KH <gregkh@linuxfoundation.org> - 2016-01-21 21:00 +0100
    Re: [PATCH] dma-buf/fence: fix timeline str value on  fence_annotate_wait_on Gustavo Padovan <gustavo.padovan@collabora.co.uk> - 2016-01-21 21:10 +0100
      Re: [PATCH] dma-buf/fence: fix timeline str value on  fence_annotate_wait_on Greg KH <gregkh@linuxfoundation.org> - 2016-01-21 21:40 +0100

csiph-web