Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1314310 > unrolled thread

[GIT PULL 00/16] perf/core improvements and changes

Started byArnaldo Carvalho de Melo <acme@kernel.org>
First post2016-01-21 17:10 +0100
Last post2016-01-21 17:10 +0100
Articles 4 — 1 participant

Back to article view | Back to linux.kernel

Contents

  [GIT PULL 00/16] perf/core improvements and changes Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-21 17:10 +0100
    [PATCH 06/16] perf stat: Do not clean event's private stats Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-21 17:10 +0100
    [PATCH 01/16] perf tests: Remove wrong semicolon in while loop in CQM test Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-21 17:10 +0100
    [PATCH 11/16] perf annotate: Rename 'colors.code' to 'colors.jump_arrows' Arnaldo Carvalho de Melo <acme@kernel.org> - 2016-01-21 17:10 +0100

#1314310 — [GIT PULL 00/16] perf/core improvements and changes

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-21 17:10 +0100
Subject[GIT PULL 00/16] perf/core improvements and changes
Message-ID<qTpY5-7Ez-3@gated-at.bofh.it>
Hi Ingo,

	Please consider pulling,

- Arnaldo

The following changes since commit f5540ecb8910cb2bc923c50b4ca5e7a50a9bf775:

  Merge tag 'perf-core-for-mingo' of git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux into perf/urgent (2016-01-19 08:30:48 +0100)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git tags/perf-core-for-mingo

for you to fetch changes up to 888b1187f17cff61527d6f9c314a63311f784dca:

  perf config: Document 'hist.percentage' variable in man page (2016-01-21 11:55:21 -0300)

----------------------------------------------------------------
perf/core improvements and fixes:

User visible:

- Rename the "colors.code" ~/.perfconfig variable to "colors.jump_arrows",
  as it controls just the that UI element in the annotate browser (Taeung Song)

- Fix 'perf test CQM' endless loop detected by 'gcc6 -Wmisleading-indentation'
  (Markus Trippelsdorf)

- Fix behaviour of Shift-Tab when nothing focussed in the annotate TUI browser,
  detected with gcc6 -Wmisleading-indentation (Markus Trippelsdorf)

- Avoid trying to read ELF symtabs from device files, noticed while doing
  memory profiling work (Jiri Olsa)

- Fix mem data cacheline hists browser widht setting for unresolved
  addresses (Jiri Olsa)

- Fix 'perf stat' stddev reporting due to mistakenly cleaning event
  private stats (Jiri Olsa)

Infrastructure:

- Elliminate duplication in the hists browser filter functions, getting the
  common part into a function that receives callbacks for filtering by
  DSO, thread, etc (Namhyung Kim)

Documentation:

- Document the perf sysctls in Documentation/sysctl/kernel.txt (Ben Hutchings)

- Document a bunch more ~/.perfconfig knobs (Taeung Song)

Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

----------------------------------------------------------------
Ben Hutchings (1):
      perf tools: Document the perf sysctls

Jiri Olsa (4):
      perf symbols: Do not read symbols/data from device files
      perf hists: Fix HISTC_MEM_DCACHELINE width setting
      perf stat: Do not clean event's private stats
      perf stat: Making several helper functions static

Markus Trippelsdorf (3):
      perf tests: Remove wrong semicolon in while loop in CQM test
      perf annotate browser: Fix behaviour of Shift-Tab with nothing focussed
      perf pmu: Fix misleadingly indented assignment (whitespace)

Namhyung Kim (2):
      perf hists: Remove parent filter check in DSO filter function
      perf hists: Cleanup filtering functions

Taeung Song (6):
      perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
      perf config: Document variables for 'colors' section in man page
      perf config: Document variables for 'tui' and 'gtk' sections in man page
      perf config: Document 'buildid.dir' variable in man page
      perf config: Document variables for 'annotate' section in man page
      perf config: Document 'hist.percentage' variable in man page

 Documentation/sysctl/kernel.txt             |  13 ++
 tools/perf/Documentation/perf-config.txt    | 200 +++++++++++++++++++++++++++-
 tools/perf/Documentation/perfconfig.example |   2 +-
 tools/perf/arch/x86/tests/intel-cqm.c       |   2 +-
 tools/perf/ui/browser.c                     |   4 +-
 tools/perf/ui/browser.h                     |   2 +-
 tools/perf/ui/browsers/annotate.c           |   6 +-
 tools/perf/util/dso.c                       |   5 +
 tools/perf/util/evsel.c                     |  15 ++-
 tools/perf/util/hist.c                      |  94 +++++--------
 tools/perf/util/pmu.c                       |   2 +-
 tools/perf/util/stat.c                      |  15 +--
 tools/perf/util/stat.h                      |  10 --
 tools/perf/util/symbol.c                    |   6 +-
 tools/perf/util/util.c                      |  10 ++
 tools/perf/util/util.h                      |   1 +
 16 files changed, 289 insertions(+), 98 deletions(-)

[toc] | [next] | [standalone]

#1314312 — [PATCH 06/16] perf stat: Do not clean event's private stats

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-21 17:10 +0100
Subject[PATCH 06/16] perf stat: Do not clean event's private stats
Message-ID<qTpY7-7Ez-41@gated-at.bofh.it>
In reply to#1314310
From: Jiri Olsa <jolsa@kernel.org>

Mel reported stddev reporting was broken due to following commit:

	106a94a0f8c2 ("perf stat: Introduce read_counters function")

This commit merged interval and overall counters reading into single
read_counters function.

The old interval code cleaned the stddev data for some reason (it's
never displayed in interval mode) and the mentioned commit kept on
cleaning the stddev data in merged function, which resulted in the
stddev not being displayed.

Removing the wrong stddev data cleanup init_stats call.

Reported-and-Tested-by: Mel Gorman <mgorman@techsingularity.net>
Signed-off-by: Jiri Olsa <jolsa@kernel.org>
Cc: David Ahern <dsahern@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: stable@vger.kernel.org # v4.2+
Fixes: 106a94a0f8c2 ("perf stat: Introduce read_counters function")
Link: http://lkml.kernel.org/r/1453290995-18485-4-git-send-email-jolsa@kernel.org
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/util/stat.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/tools/perf/util/stat.c b/tools/perf/util/stat.c
index 2f901d15e063..2b58edccd56f 100644
--- a/tools/perf/util/stat.c
+++ b/tools/perf/util/stat.c
@@ -310,7 +310,6 @@ int perf_stat_process_counter(struct perf_stat_config *config,
 	int i, ret;
 
 	aggr->val = aggr->ena = aggr->run = 0;
-	init_stats(ps->res_stats);
 
 	if (counter->per_pkg)
 		zero_per_pkg(counter);
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1314313 — [PATCH 01/16] perf tests: Remove wrong semicolon in while loop in CQM test

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-21 17:10 +0100
Subject[PATCH 01/16] perf tests: Remove wrong semicolon in while loop in CQM test
Message-ID<qTpY7-7Ez-43@gated-at.bofh.it>
In reply to#1314310
From: Markus Trippelsdorf <markus@trippelsdorf.de>

The while loop was spinning. Fix by removing a semicolon.

The issue was pointed out by gcc-6's -Wmisleading-indentation.

Signed-off-by: Markus Trippelsdorf <markus@trippelsdorf.de>
Reviewed-by: Matt Fleming <matt@codeblueprint.co.uk>
Acked-by: Ingo Molnar <mingo@kernel.org>
Cc: Ben Hutchings <ben@decadent.org.uk>
Cc: Peter Zijlstra <peterz@infradead.org>
Fixes: 035827e9f2bd ("perf tests: Add Intel CQM test")
Link: http://lkml.kernel.org/r/20151214154335.GA1409@x4
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/arch/x86/tests/intel-cqm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/arch/x86/tests/intel-cqm.c b/tools/perf/arch/x86/tests/intel-cqm.c
index 3e89ba825f6b..7f064eb37158 100644
--- a/tools/perf/arch/x86/tests/intel-cqm.c
+++ b/tools/perf/arch/x86/tests/intel-cqm.c
@@ -17,7 +17,7 @@ static pid_t spawn(void)
 	if (pid)
 		return pid;
 
-	while(1);
+	while(1)
 		sleep(5);
 	return 0;
 }
-- 
2.5.0

[toc] | [prev] | [next] | [standalone]

#1314314 — [PATCH 11/16] perf annotate: Rename 'colors.code' to 'colors.jump_arrows'

FromArnaldo Carvalho de Melo <acme@kernel.org>
Date2016-01-21 17:10 +0100
Subject[PATCH 11/16] perf annotate: Rename 'colors.code' to 'colors.jump_arrows'
Message-ID<qTpY7-7Ez-45@gated-at.bofh.it>
In reply to#1314310
From: Taeung Song <treeze.taeung@gmail.com>

USe 'jump_arrows' config name instead of 'code' on 'colors' section.
'colors.code' config is only for jump arrows on assembly code listings
i.e.

    │     ┌──jmp    1333
    │     │  xchg   %ax,%ax
    │     │  mov    %r15,%r10
    │     └─→cmp    %r15,%r14

But this config name seems unfit.

 'jump_arrows' is more descriptive than 'code'.

Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/r/1452240971-25418-1-git-send-email-treeze.taeung@gmail.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/Documentation/perf-config.txt    | 2 +-
 tools/perf/Documentation/perfconfig.example | 2 +-
 tools/perf/ui/browser.c                     | 4 ++--
 tools/perf/ui/browser.h                     | 2 +-
 tools/perf/ui/browsers/annotate.c           | 2 +-
 5 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/tools/perf/Documentation/perf-config.txt b/tools/perf/Documentation/perf-config.txt
index b9ca1e304158..1ee488b9aaf7 100644
--- a/tools/perf/Documentation/perf-config.txt
+++ b/tools/perf/Documentation/perf-config.txt
@@ -62,7 +62,7 @@ Given a $HOME/.perfconfig like this:
 		medium = green, default
 		normal = lightgray, default
 		selected = white, lightgray
-		code = blue, default
+		jump_arrows = blue, default
 		addr = magenta, default
 		root = white, blue
 
diff --git a/tools/perf/Documentation/perfconfig.example b/tools/perf/Documentation/perfconfig.example
index 767ea2436e1c..1d8d5bc4cd2d 100644
--- a/tools/perf/Documentation/perfconfig.example
+++ b/tools/perf/Documentation/perfconfig.example
@@ -5,7 +5,7 @@
 	medium = green, lightgray
 	normal = black, lightgray
 	selected = lightgray, magenta
-	code = blue, lightgray
+	jump_arrows = blue, lightgray
 	addr = magenta, lightgray
 
 [tui]
diff --git a/tools/perf/ui/browser.c b/tools/perf/ui/browser.c
index d37202121689..af68a9d488bf 100644
--- a/tools/perf/ui/browser.c
+++ b/tools/perf/ui/browser.c
@@ -531,8 +531,8 @@ static struct ui_browser_colorset {
 		.bg	  = "yellow",
 	},
 	{
-		.colorset = HE_COLORSET_CODE,
-		.name	  = "code",
+		.colorset = HE_COLORSET_JUMP_ARROWS,
+		.name	  = "jump_arrows",
 		.fg	  = "blue",
 		.bg	  = "default",
 	},
diff --git a/tools/perf/ui/browser.h b/tools/perf/ui/browser.h
index 01781de59532..be3b70eb5fca 100644
--- a/tools/perf/ui/browser.h
+++ b/tools/perf/ui/browser.h
@@ -7,7 +7,7 @@
 #define HE_COLORSET_MEDIUM	51
 #define HE_COLORSET_NORMAL	52
 #define HE_COLORSET_SELECTED	53
-#define HE_COLORSET_CODE	54
+#define HE_COLORSET_JUMP_ARROWS	54
 #define HE_COLORSET_ADDR	55
 #define HE_COLORSET_ROOT	56
 
diff --git a/tools/perf/ui/browsers/annotate.c b/tools/perf/ui/browsers/annotate.c
index 718bd46d47fa..4fc208e82c6f 100644
--- a/tools/perf/ui/browsers/annotate.c
+++ b/tools/perf/ui/browsers/annotate.c
@@ -284,7 +284,7 @@ static void annotate_browser__draw_current_jump(struct ui_browser *browser)
 		to = (u64)btarget->idx;
 	}
 
-	ui_browser__set_color(browser, HE_COLORSET_CODE);
+	ui_browser__set_color(browser, HE_COLORSET_JUMP_ARROWS);
 	__ui_browser__line_arrow(browser, pcnt_width + 2 + ab->addr_width,
 				 from, to);
 }
-- 
2.5.0

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web