Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311633 > unrolled thread

[PATCH] drm/i915: fix itnull.cocci warnings (fwd)

Started byJulia Lawall <julia.lawall@lip6.fr>
First post2016-01-18 16:50 +0100
Last post2016-01-20 11:10 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

Contents

  [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Julia Lawall <julia.lawall@lip6.fr> - 2016-01-18 16:50 +0100
    Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Daniel Vetter <daniel@ffwll.ch> - 2016-01-18 18:30 +0100
      Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Eric Engestrom <eric.engestrom@imgtec.com> - 2016-01-18 18:50 +0100
        Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Daniel Vetter <daniel@ffwll.ch> - 2016-01-18 19:10 +0100
      Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Julia Lawall <julia.lawall@lip6.fr> - 2016-01-18 21:30 +0100
      Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-01-20 11:10 +0100

#1311633 — [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-01-18 16:50 +0100
Subject[PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSke7-2DG-33@gated-at.bofh.it>
List_for_each entry binds its first argument to an offset from the list
pointer, so this should not be NULL.

Generated by: scripts/coccinelle/iterators/itnull.cocci

Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
---

Please take the patch only if it's a positive warning. Thanks!

 intel_display.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/drm/i915/intel_display.c
@@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
 		struct intel_flip_work *work;

 		list_for_each_entry(work, &crtc->flip_work, head) {
-			if (work && work->event &&
+			if (work->event &&
 			    work->event->base.file_priv == file) {
 				kfree(work->event);
 				work->event = NULL;

[toc] | [next] | [standalone]

#1311702 — Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromDaniel Vetter <daniel@ffwll.ch>
Date2016-01-18 18:30 +0100
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSlMS-3S4-19@gated-at.bofh.it>
In reply to#1311633
On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> List_for_each entry binds its first argument to an offset from the list
> pointer, so this should not be NULL.
> 
> Generated by: scripts/coccinelle/iterators/itnull.cocci
> 
> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> ---
> 
> Please take the patch only if it's a positive warning. Thanks!

Against which tree is this? I can't find this anywhere like that ...
-Daniel

> 
>  intel_display.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- a/drivers/gpu/drm/i915/intel_display.c
> +++ b/drivers/gpu/drm/i915/intel_display.c
> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>  		struct intel_flip_work *work;
> 
>  		list_for_each_entry(work, &crtc->flip_work, head) {
> -			if (work && work->event &&
> +			if (work->event &&
>  			    work->event->base.file_priv == file) {
>  				kfree(work->event);
>  				work->event = NULL;
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [next] | [standalone]

#1311710 — Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromEric Engestrom <eric.engestrom@imgtec.com>
Date2016-01-18 18:50 +0100
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSm6d-3ZZ-3@gated-at.bofh.it>
In reply to#1311702
I expect this is the script she mentions:
https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci

Julia is one of the authors of Coccinelle, and the author of that script :)


On 18/01/16 17:20, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
>> List_for_each entry binds its first argument to an offset from the list
>> pointer, so this should not be NULL.
>>
>> Generated by: scripts/coccinelle/iterators/itnull.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> Please take the patch only if it's a positive warning. Thanks!
> 
> Against which tree is this? I can't find this anywhere like that ...
> -Daniel
> 
>>
>>  intel_display.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>>  		struct intel_flip_work *work;
>>
>>  		list_for_each_entry(work, &crtc->flip_work, head) {
>> -			if (work && work->event &&
>> +			if (work->event &&
>>  			    work->event->base.file_priv == file) {
>>  				kfree(work->event);
>>  				work->event = NULL;
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
>

[toc] | [prev] | [next] | [standalone]

#1311731 — Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromDaniel Vetter <daniel@ffwll.ch>
Date2016-01-18 19:10 +0100
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSmpC-4nb-39@gated-at.bofh.it>
In reply to#1311710
On Mon, Jan 18, 2016 at 05:42:24PM +0000, Eric Engestrom wrote:
> I expect this is the script she mentions:
> https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci
> 
> Julia is one of the authors of Coccinelle, and the author of that script :)

I get how these patches get created, I just can't find a tree anywhere
where this applies. So I wonder what it was generated against ...
-Daniel

> 
> 
> On 18/01/16 17:20, Daniel Vetter wrote:
> > On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> >> List_for_each entry binds its first argument to an offset from the list
> >> pointer, so this should not be NULL.
> >>
> >> Generated by: scripts/coccinelle/iterators/itnull.cocci
> >>
> >> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> >> ---
> >>
> >> Please take the patch only if it's a positive warning. Thanks!
> > 
> > Against which tree is this? I can't find this anywhere like that ...
> > -Daniel
> > 
> >>
> >>  intel_display.c |    2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> --- a/drivers/gpu/drm/i915/intel_display.c
> >> +++ b/drivers/gpu/drm/i915/intel_display.c
> >> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
> >>  		struct intel_flip_work *work;
> >>
> >>  		list_for_each_entry(work, &crtc->flip_work, head) {
> >> -			if (work && work->event &&
> >> +			if (work->event &&
> >>  			    work->event->base.file_priv == file) {
> >>  				kfree(work->event);
> >>  				work->event = NULL;
> >> _______________________________________________
> >> Intel-gfx mailing list
> >> Intel-gfx@lists.freedesktop.org
> >> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> > 

-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch

[toc] | [prev] | [next] | [standalone]

#1311792 — Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromJulia Lawall <julia.lawall@lip6.fr>
Date2016-01-18 21:30 +0100
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSoB3-5HY-13@gated-at.bofh.it>
In reply to#1311702

On Mon, 18 Jan 2016, Daniel Vetter wrote:

> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
> > List_for_each entry binds its first argument to an offset from the list
> > pointer, so this should not be NULL.
> > 
> > Generated by: scripts/coccinelle/iterators/itnull.cocci
> > 
> > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
> > ---
> > 
> > Please take the patch only if it's a positive warning. Thanks!
> 
> Against which tree is this? I can't find this anywhere like that ...

I don't know.  It may be against a submitted patch.

In case it turns out to be useful, I forgot:

Signed-off-by: Julia Lawall <julia.lawall@lip6.fr>


> -Daniel
> 
> > 
> >  intel_display.c |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/drivers/gpu/drm/i915/intel_display.c
> > @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
> >  		struct intel_flip_work *work;
> > 
> >  		list_for_each_entry(work, &crtc->flip_work, head) {
> > -			if (work && work->event &&
> > +			if (work->event &&
> >  			    work->event->base.file_priv == file) {
> >  				kfree(work->event);
> >  				work->event = NULL;
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 
> -- 
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>

[toc] | [prev] | [next] | [standalone]

#1313050 — Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

FromMaarten Lankhorst <maarten.lankhorst@linux.intel.com>
Date2016-01-20 11:10 +0100
SubjectRe: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)
Message-ID<qSXS9-4UA-1@gated-at.bofh.it>
In reply to#1311702
Op 18-01-16 om 18:20 schreef Daniel Vetter:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
>> List_for_each entry binds its first argument to an offset from the list
>> pointer, so this should not be NULL.
>>
>> Generated by: scripts/coccinelle/iterators/itnull.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> Please take the patch only if it's a positive warning. Thanks!
> Against which tree is this? I can't find this anywhere like that ...
>
Looks to like it happens in my tree.

drm/i915: Convert flip_work to a list.

~Maarten

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web