Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1311710

Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd)

Show all headers | View raw

I expect this is the script she mentions:
https://github.com/coccinelle/coccinellery/blob/master/itnull/itnull.cocci

Julia is one of the authors of Coccinelle, and the author of that script :)


On 18/01/16 17:20, Daniel Vetter wrote:
> On Mon, Jan 18, 2016 at 04:49:06PM +0100, Julia Lawall wrote:
>> List_for_each entry binds its first argument to an offset from the list
>> pointer, so this should not be NULL.
>>
>> Generated by: scripts/coccinelle/iterators/itnull.cocci
>>
>> Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
>> ---
>>
>> Please take the patch only if it's a positive warning. Thanks!
> 
> Against which tree is this? I can't find this anywhere like that ...
> -Daniel
> 
>>
>>  intel_display.c |    2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> --- a/drivers/gpu/drm/i915/intel_display.c
>> +++ b/drivers/gpu/drm/i915/intel_display.c
>> @@ -16498,7 +16498,7 @@ void intel_modeset_preclose(struct drm_d
>>  		struct intel_flip_work *work;
>>
>>  		list_for_each_entry(work, &crtc->flip_work, head) {
>> -			if (work && work->event &&
>> +			if (work->event &&
>>  			    work->event->base.file_priv == file) {
>>  				kfree(work->event);
>>  				work->event = NULL;
>> _______________________________________________
>> Intel-gfx mailing list
>> Intel-gfx@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/intel-gfx
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] drm/i915: fix itnull.cocci warnings (fwd) Julia Lawall <julia.lawall@lip6.fr> - 2016-01-18 16:50 +0100
  Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Daniel Vetter <daniel@ffwll.ch> - 2016-01-18 18:30 +0100
    Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Eric Engestrom <eric.engestrom@imgtec.com> - 2016-01-18 18:50 +0100
      Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Daniel Vetter <daniel@ffwll.ch> - 2016-01-18 19:10 +0100
    Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Julia Lawall <julia.lawall@lip6.fr> - 2016-01-18 21:30 +0100
    Re: [Intel-gfx] [PATCH] drm/i915: fix itnull.cocci warnings (fwd) Maarten Lankhorst <maarten.lankhorst@linux.intel.com> - 2016-01-20 11:10 +0100

csiph-web