Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313103 > unrolled thread

Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match Mark Brown <broonie@kernel.org> - 2016-01-20 11:50 +0100
    Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match Arnd Bergmann <arnd@arndb.de> - 2016-01-20 12:00 +0100

#1313103 — Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match

[Multipart message — attachments visible in raw view] — view raw

On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote:
> The newly added rt5659 codec driver unconditionally defines an
> ACPI device match table but then uses ACPI_PTR() to remove the
> only reference to it, so we get a harmless build warning:

> sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable]
>  static struct acpi_device_id rt5659_acpi_match[] = {

> This removes the ACPI_PTR() to avoid the warning.

Why is this a better fix than conditionally defining the table?

[toc] | [next] | [standalone]

#1313119

On Wednesday 20 January 2016 10:45:55 Mark Brown wrote:
> On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote:
> > The newly added rt5659 codec driver unconditionally defines an
> > ACPI device match table but then uses ACPI_PTR() to remove the
> > only reference to it, so we get a harmless build warning:
> 
> > sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable]
> >  static struct acpi_device_id rt5659_acpi_match[] = {
> 
> > This removes the ACPI_PTR() to avoid the warning.
> 
> Why is this a better fix than conditionally defining the table?

I'm not overly fond of adding #ifdef if it can be avoided. In this case,
both approaches seemed reasonable (either add an #ifdef or waste a couple
of bytes), and I picked at random. I'll send you the alternative as well,
please apply whichever one you prefer.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web