Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1313103

Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Wed, Jan 20, 2016 at 11:43:48AM +0100, Arnd Bergmann wrote:
> The newly added rt5659 codec driver unconditionally defines an
> ACPI device match table but then uses ACPI_PTR() to remove the
> only reference to it, so we get a harmless build warning:

> sound/soc/codecs/rt5659.c:4200:30: warning: 'rt5659_acpi_match' defined but not used [-Wunused-variable]
>  static struct acpi_device_id rt5659_acpi_match[] = {

> This removes the ACPI_PTR() to avoid the warning.

Why is this a better fix than conditionally defining the table?

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match Mark Brown <broonie@kernel.org> - 2016-01-20 11:50 +0100
  Re: [PATCH] ASoC: avoid unused variable warning for rt5659_acpi_match Arnd Bergmann <arnd@arndb.de> - 2016-01-20 12:00 +0100

csiph-web