Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310940 > unrolled thread
| Started by | Andreas Kemnade <andreas@kemnade.info> |
|---|---|
| First post | 2016-01-16 13:50 +0100 |
| Last post | 2016-01-19 19:20 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[PATCH RESEND] omap_hdq: fix usecount handling Andreas Kemnade <andreas@kemnade.info> - 2016-01-16 13:50 +0100
Re: [PATCH RESEND] omap_hdq: fix usecount handling Vignesh R <vigneshr@ti.com> - 2016-01-19 13:00 +0100
Re: [PATCH RESEND] omap_hdq: fix usecount handling Evgeniy Polyakov <zbr@ioremap.net> - 2016-01-19 17:50 +0100
Re: [PATCH RESEND] omap_hdq: fix usecount handling "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-01-19 19:20 +0100
| From | Andreas Kemnade <andreas@kemnade.info> |
|---|---|
| Date | 2016-01-16 13:50 +0100 |
| Subject | [PATCH RESEND] omap_hdq: fix usecount handling |
| Message-ID | <qRysP-4oX-13@gated-at.bofh.it> |
hdq_usecount was set to zero after a successful read, so
omap_hdq_put could not properly free resources which leads
e.g. to increasing usecounts in lsmod output
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
drivers/w1/masters/omap_hdq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
index 0e2f43b..a2eec97 100644
--- a/drivers/w1/masters/omap_hdq.c
+++ b/drivers/w1/masters/omap_hdq.c
@@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
- hdq_data->hdq_usecount = 0;
/* Write followed by a read, release the module */
if (hdq_data->init_trans) {
--
2.1.4
[toc] | [next] | [standalone]
| From | Vignesh R <vigneshr@ti.com> |
|---|---|
| Date | 2016-01-19 13:00 +0100 |
| Message-ID | <qSD74-7hM-3@gated-at.bofh.it> |
| In reply to | #1310940 |
On 01/16/2016 06:18 PM, Andreas Kemnade wrote:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
Reviewed-by: Vignesh R <vigneshr@ti.com>
Thanks,
> drivers/w1/masters/omap_hdq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
> hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
> ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
> /* Write followed by a read, release the module */
> if (hdq_data->init_trans) {
>
--
Regards
Vignesh
[toc] | [prev] | [next] | [standalone]
| From | Evgeniy Polyakov <zbr@ioremap.net> |
|---|---|
| Date | 2016-01-19 17:50 +0100 |
| Message-ID | <qSHDH-23d-5@gated-at.bofh.it> |
| In reply to | #1310940 |
Hi Andreas
From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.
Acked-by: Evgeniy Polyakov <zbr@ioremap.net>
16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
> drivers/w1/masters/omap_hdq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
> hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
> ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
> /* Write followed by a read, release the module */
> if (hdq_data->init_trans) {
> --
> 2.1.4
[toc] | [prev] | [next] | [standalone]
| From | "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> |
|---|---|
| Date | 2016-01-19 19:20 +0100 |
| Message-ID | <qSJ2O-36W-11@gated-at.bofh.it> |
| In reply to | #1312378 |
On Tue, Jan 19, 2016 at 07:38:28PM +0300, Evgeniy Polyakov wrote: > Hi Andreas > > >From w1 perspective this doesn't break things :) > Greg, please pull it into your tree if no one objects. > > Acked-by: Evgeniy Polyakov <zbr@ioremap.net> Thanks, will do after 4.5-rc1 is out. greg k-h
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web