Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1312378

Re: [PATCH RESEND] omap_hdq: fix usecount handling

Show all headers | View raw

Hi Andreas

From w1 perspective this doesn't break things :)
Greg, please pull it into your tree if no one objects.

Acked-by: Evgeniy Polyakov <zbr@ioremap.net>

16.01.2016, 15:48, "Andreas Kemnade" <andreas@kemnade.info>:
> hdq_usecount was set to zero after a successful read, so
> omap_hdq_put could not properly free resources which leads
> e.g. to increasing usecounts in lsmod output
>
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
> ---
>  drivers/w1/masters/omap_hdq.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/w1/masters/omap_hdq.c b/drivers/w1/masters/omap_hdq.c
> index 0e2f43b..a2eec97 100644
> --- a/drivers/w1/masters/omap_hdq.c
> +++ b/drivers/w1/masters/omap_hdq.c
> @@ -618,7 +618,6 @@ static u8 omap_w1_read_byte(void *_hdq)
>
>          hdq_disable_interrupt(hdq_data, OMAP_HDQ_CTRL_STATUS,
>                                ~OMAP_HDQ_CTRL_STATUS_INTERRUPTMASK);
> - hdq_data->hdq_usecount = 0;
>
>          /* Write followed by a read, release the module */
>          if (hdq_data->init_trans) {
> --
> 2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH RESEND] omap_hdq: fix usecount handling Andreas Kemnade <andreas@kemnade.info> - 2016-01-16 13:50 +0100
  Re: [PATCH RESEND] omap_hdq: fix usecount handling Vignesh R <vigneshr@ti.com> - 2016-01-19 13:00 +0100
  Re: [PATCH RESEND] omap_hdq: fix usecount handling Evgeniy Polyakov <zbr@ioremap.net> - 2016-01-19 17:50 +0100
    Re: [PATCH RESEND] omap_hdq: fix usecount handling "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org> - 2016-01-19 19:20 +0100

csiph-web