Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1310341 > unrolled thread
| Started by | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| First post | 2016-01-15 19:10 +0100 |
| Last post | 2016-01-16 19:40 +0100 |
| Articles | 3 — 3 participants |
Back to article view | Back to linux.kernel
[PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-15 19:10 +0100
Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-15 22:00 +0100
Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-16 19:40 +0100
| From | Grygorii Strashko <grygorii.strashko@ti.com> |
|---|---|
| Date | 2016-01-15 19:10 +0100 |
| Subject | [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() |
| Message-ID | <qRgYV-1jy-11@gated-at.bofh.it> |
Now serio_find_driver() will print warnings in case device_attach()
returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
- DD core can report the same if required
- since commit 013c074f8642 ("PM / sleep: prohibit devices probing
during suspend/hibernation") the devices probing is prohibited during
System suspend and deferred device will be carefully reprobed once
Resume is finished.
Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
---
drivers/input/serio/serio.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
index 8f82897..1ca7f55 100644
--- a/drivers/input/serio/serio.c
+++ b/drivers/input/serio/serio.c
@@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
int error;
error = device_attach(&serio->dev);
- if (error < 0)
+ if (error < 0 && error != -EPROBE_DEFER)
dev_warn(&serio->dev,
"device_attach() failed for %s (%s), error: %d\n",
serio->phys, serio->name, error);
--
2.7.0
[toc] | [next] | [standalone]
| From | "Rafael J. Wysocki" <rjw@rjwysocki.net> |
|---|---|
| Date | 2016-01-15 22:00 +0100 |
| Message-ID | <qRjDs-2R7-13@gated-at.bofh.it> |
| In reply to | #1310341 |
On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> Now serio_find_driver() will print warnings in case device_attach()
> returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> - DD core can report the same if required
> - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> during suspend/hibernation") the devices probing is prohibited during
> System suspend and deferred device will be carefully reprobed once
> Resume is finished.
>
> Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
>
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/input/serio/serio.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> index 8f82897..1ca7f55 100644
> --- a/drivers/input/serio/serio.c
> +++ b/drivers/input/serio/serio.c
> @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
> int error;
>
> error = device_attach(&serio->dev);
> - if (error < 0)
> + if (error < 0 && error != -EPROBE_DEFER)
> dev_warn(&serio->dev,
> "device_attach() failed for %s (%s), error: %d\n",
> serio->phys, serio->name, error);
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
[toc] | [prev] | [next] | [standalone]
| From | Dmitry Torokhov <dmitry.torokhov@gmail.com> |
|---|---|
| Date | 2016-01-16 19:40 +0100 |
| Subject | Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() |
| Message-ID | <qRDVv-88K-3@gated-at.bofh.it> |
| In reply to | #1310459 |
On Fri, Jan 15, 2016 at 09:53:14PM +0100, Rafael J. Wysocki wrote:
> On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> > Now serio_find_driver() will print warnings in case device_attach()
> > returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> > - DD core can report the same if required
> > - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> > during suspend/hibernation") the devices probing is prohibited during
> > System suspend and deferred device will be carefully reprobed once
> > Resume is finished.
> >
> > Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
> >
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> > Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
>
> Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Applied, thank you.
>
> > ---
> > drivers/input/serio/serio.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> > index 8f82897..1ca7f55 100644
> > --- a/drivers/input/serio/serio.c
> > +++ b/drivers/input/serio/serio.c
> > @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
> > int error;
> >
> > error = device_attach(&serio->dev);
> > - if (error < 0)
> > + if (error < 0 && error != -EPROBE_DEFER)
> > dev_warn(&serio->dev,
> > "device_attach() failed for %s (%s), error: %d\n",
> > serio->phys, serio->name, error);
> >
>
> --
> I speak only for myself.
> Rafael J. Wysocki, Intel Open Source Technology Center.
--
Dmitry
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web