Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1310459

Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver()

Show all headers | View raw

On Friday, January 15, 2016 08:01:15 PM Grygorii Strashko wrote:
> Now serio_find_driver() will print warnings in case device_attach()
> returns -EPROBE_DEFER. Those warnings are obsolete, in genral, because:
> - DD core can report the same if required
> - since commit 013c074f8642 ("PM / sleep: prohibit devices probing
> during suspend/hibernation") the devices probing is prohibited during
> System suspend and deferred device will be carefully reprobed once
> Resume is finished.
> 
> Hence, drop warnings in case of EPROBE_DEFER from serio_find_driver().
> 
> Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> Cc: Rafael J. Wysocki <rjw@rjwysocki.net>
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>

Acked-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

> ---
>  drivers/input/serio/serio.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/input/serio/serio.c b/drivers/input/serio/serio.c
> index 8f82897..1ca7f55 100644
> --- a/drivers/input/serio/serio.c
> +++ b/drivers/input/serio/serio.c
> @@ -134,7 +134,7 @@ static void serio_find_driver(struct serio *serio)
>  	int error;
>  
>  	error = device_attach(&serio->dev);
> -	if (error < 0)
> +	if (error < 0 && error != -EPROBE_DEFER)
>  		dev_warn(&serio->dev,
>  			 "device_attach() failed for %s (%s), error: %d\n",
>  			 serio->phys, serio->name, error);
> 

-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() Grygorii Strashko <grygorii.strashko@ti.com> - 2016-01-15 19:10 +0100
  Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from serio_find_driver() "Rafael J. Wysocki" <rjw@rjwysocki.net> - 2016-01-15 22:00 +0100
    Re: [PATCH] input: serio: drop warnings in case of EPROBE_DEFER from  serio_find_driver() Dmitry Torokhov <dmitry.torokhov@gmail.com> - 2016-01-16 19:40 +0100

csiph-web