Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1308351 > unrolled thread
| Started by | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| First post | 2016-01-13 13:30 +0100 |
| Last post | 2016-01-13 18:10 +0100 |
| Articles | 4 — 4 participants |
Back to article view | Back to linux.kernel
[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-13 13:30 +0100
Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Jiri Pirko <jiri@resnulli.us> - 2016-01-13 14:40 +0100
Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB David Miller <davem@davemloft.net> - 2016-01-13 16:40 +0100
Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Elad Raz <eladr@mellanox.com> - 2016-01-13 18:10 +0100
| From | Dan Carpenter <dan.carpenter@oracle.com> |
|---|---|
| Date | 2016-01-13 13:30 +0100 |
| Subject | [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB |
| Message-ID | <qQsIO-84i-9@gated-at.bofh.it> |
There is a missing break statement so we always return -EOPNOTSUPP.
Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index ffe894e..45479ef 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
case SWITCHDEV_OBJ_ID_PORT_MDB:
err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
SWITCHDEV_OBJ_PORT_MDB(obj));
+ break;
default:
err = -EOPNOTSUPP;
break;
[toc] | [next] | [standalone]
| From | Jiri Pirko <jiri@resnulli.us> |
|---|---|
| Date | 2016-01-13 14:40 +0100 |
| Message-ID | <qQtOy-mT-5@gated-at.bofh.it> |
| In reply to | #1308351 |
Wed, Jan 13, 2016 at 01:28:23PM CET, dan.carpenter@oracle.com wrote:
>There is a missing break statement so we always return -EOPNOTSUPP.
>
>Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
>Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jiri Pirko <jiri@mellanox.com>
[toc] | [prev] | [next] | [standalone]
| From | David Miller <davem@davemloft.net> |
|---|---|
| Date | 2016-01-13 16:40 +0100 |
| Message-ID | <qQvGF-1Gf-5@gated-at.bofh.it> |
| In reply to | #1308351 |
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 13 Jan 2016 15:28:23 +0300
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied.
[toc] | [prev] | [next] | [standalone]
| From | Elad Raz <eladr@mellanox.com> |
|---|---|
| Date | 2016-01-13 18:10 +0100 |
| Message-ID | <qQx5M-2Pq-5@gated-at.bofh.it> |
| In reply to | #1308351 |
> On Jan 13, 2016, at 2:28 PM, Dan Carpenter <dan.carpenter@oracle.com> wrote:
>
> There is a missing break statement so we always return -EOPNOTSUPP.
>
> Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Elad Raz <eladr@mellanox.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> index ffe894e..45479ef 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
> @@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
> case SWITCHDEV_OBJ_ID_PORT_MDB:
> err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
> SWITCHDEV_OBJ_PORT_MDB(obj));
> + break;
> default:
> err = -EOPNOTSUPP;
> break;
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web