[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB

From	Dan Carpenter <dan.carpenter@oracle.com>
Newsgroups	linux.kernel
Subject	[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB
Date	2016-01-13 13:30 +0100
Message-ID	<qQsIO-84i-9@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

There is a missing break statement so we always return -EOPNOTSUPP.

Fixes: 3a49b4fde2a1 ('mlxsw: Adding layer 2 multicast support')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

diff --git a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
index ffe894e..45479ef 100644
--- a/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
+++ b/drivers/net/ethernet/mellanox/mlxsw/spectrum_switchdev.c
@@ -1015,6 +1015,7 @@ static int mlxsw_sp_port_obj_del(struct net_device *dev,
 	case SWITCHDEV_OBJ_ID_PORT_MDB:
 		err = mlxsw_sp_port_mdb_del(mlxsw_sp_port,
 					    SWITCHDEV_OBJ_PORT_MDB(obj));
+		break;
 	default:
 		err = -EOPNOTSUPP;
 		break;

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Dan Carpenter <dan.carpenter@oracle.com> - 2016-01-13 13:30 +0100
  Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Jiri Pirko <jiri@resnulli.us> - 2016-01-13 14:40 +0100
  Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB David Miller <davem@davemloft.net> - 2016-01-13 16:40 +0100
  Re: [patch] mlxsw: fix SWITCHDEV_OBJ_ID_PORT_MDB Elad Raz <eladr@mellanox.com> - 2016-01-13 18:10 +0100

csiph-web