Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1307627 > unrolled thread

Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

Started byBorislav Petkov <bp@alien8.de>
First post2016-01-12 18:00 +0100
Last post2016-01-12 18:00 +0100
Articles 2 — 1 participant

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.


Contents

  Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in  aesni-intel_asm.S Borislav Petkov <bp@alien8.de> - 2016-01-12 18:00 +0100
    Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in  aesni-intel_asm.S Borislav Petkov <bp@alien8.de> - 2016-01-12 18:00 +0100

#1307627 — Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

FromBorislav Petkov <bp@alien8.de>
Date2016-01-12 18:00 +0100
SubjectRe: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S
Message-ID<qQasx-3AC-1@gated-at.bofh.it>
On Fri, Dec 18, 2015 at 06:39:29AM -0600, Josh Poimboeuf wrote:
> aesni-intel_asm.S has several callable non-leaf functions which don't
> honor CONFIG_FRAME_POINTER, which can result in bad stack traces.
> 
> Create stack frames for them when CONFIG_FRAME_POINTER is enabled.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Mathias Krause <minipli@ld-linux.so>
> ---
>  arch/x86/crypto/aesni-intel_asm.S | 73 ++++++++++++++++++++++++---------------
>  1 file changed, 46 insertions(+), 27 deletions(-)

After this one it says

stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init(): can't find starting instruction
stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init()+0x24: return instruction outside of a callable function

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [next] | [standalone]


#1307634

FromBorislav Petkov <bp@alien8.de>
Date2016-01-12 18:00 +0100
Message-ID<qQasz-3AC-25@gated-at.bofh.it>
In reply to#1307627
On Tue, Jan 12, 2016 at 05:53:00PM +0100, Borislav Petkov wrote:
> After this one it says
> 
> stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init(): can't find starting instruction
> stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init()+0x24: return instruction outside of a callable function

...and patch 16 fixes it.

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

[toc] | [prev] | [standalone]


Back to top | Article view | linux.kernel


csiph-web