Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1307627

Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S

From Borislav Petkov <bp@alien8.de>
Newsgroups linux.kernel
Subject Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in aesni-intel_asm.S
Date 2016-01-12 18:00 +0100
Message-ID <qQasx-3AC-1@gated-at.bofh.it> (permalink)
References <qH2DT-5IP-3@gated-at.bofh.it> <qH2DU-5IP-13@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Fri, Dec 18, 2015 at 06:39:29AM -0600, Josh Poimboeuf wrote:
> aesni-intel_asm.S has several callable non-leaf functions which don't
> honor CONFIG_FRAME_POINTER, which can result in bad stack traces.
> 
> Create stack frames for them when CONFIG_FRAME_POINTER is enabled.
> 
> Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>
> Cc: David S. Miller <davem@davemloft.net>
> Cc: Mathias Krause <minipli@ld-linux.so>
> ---
>  arch/x86/crypto/aesni-intel_asm.S | 73 ++++++++++++++++++++++++---------------
>  1 file changed, 46 insertions(+), 27 deletions(-)

After this one it says

stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init(): can't find starting instruction
stacktool: arch/x86/crypto/aesni-intel_asm.o: _aesni_inc_init()+0x24: return instruction outside of a callable function

-- 
Regards/Gruss,
    Boris.

ECO tip #101: Trim your mails when you reply.

Back to linux.kernel | Previous | NextNext in thread | Find similar | Unroll thread


Thread

Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in  aesni-intel_asm.S Borislav Petkov <bp@alien8.de> - 2016-01-12 18:00 +0100
  Re: [PATCH v15 15/25] x86/asm/crypto: Create stack frames in  aesni-intel_asm.S Borislav Petkov <bp@alien8.de> - 2016-01-12 18:00 +0100

csiph-web