Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1308894 > unrolled thread

[PATCH] clocksource: ftm: select CLKSRC_MMIO

Back to article view | Back to linux.kernel

Contents

  [PATCH] clocksource: ftm: select CLKSRC_MMIO Arnd Bergmann <arnd@arndb.de> - 2016-01-14 00:10 +0100
    Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-01-14 10:30 +0100
      Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO Arnd Bergmann <arnd@arndb.de> - 2016-01-14 13:30 +0100

#1308894 — [PATCH] clocksource: ftm: select CLKSRC_MMIO

The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:

drivers/built-in.o: In function `ftm_timer_init':
(init.text+0xd324): undefined reference to `clocksource_mmio_init'
(init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'

This adds the same 'select' statement that the other similar drivers
use. Prior to allowing this driver to be enabled with COMPILE_TEST,
it was apparently unused. I'm not entirely sure who is using this
hardware, but it certainly can't hurt to ensure it builds cleanly.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: ef49336bbd15 ("clocksource/drivers/fsl-ftm: Add the COMPILE_TEST option")

diff --git a/drivers/clocksource/Kconfig b/drivers/clocksource/Kconfig
index b251013eef0a..d3ad9512312b 100644
--- a/drivers/clocksource/Kconfig
+++ b/drivers/clocksource/Kconfig
@@ -256,6 +256,7 @@ config CLKSRC_SAMSUNG_PWM
 config FSL_FTM_TIMER
 	bool "Freescale FlexTimer Module driver" if COMPILE_TEST
 	depends on GENERIC_CLOCKEVENTS
+	select CLKSRC_MMIO
 	help
 	  Support for Freescale FlexTimer Module (FTM) timer.
 

[toc] | [next] | [standalone]

#1309112

On 01/14/2016 12:02 AM, Arnd Bergmann wrote:
> The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:
>
> drivers/built-in.o: In function `ftm_timer_init':
> (init.text+0xd324): undefined reference to `clocksource_mmio_init'
> (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'
>
> This adds the same 'select' statement that the other similar drivers
> use. Prior to allowing this driver to be enabled with COMPILE_TEST,
> it was apparently unused. I'm not entirely sure who is using this
> hardware, but it certainly can't hurt to ensure it builds cleanly.

Hi Arnd,

Thanks for the fix. It is already in Thomas's tree [1].

It has been merged in tip/timers/urgent. You will have to wait a bit 
this branch to be merged with tip/timers/core.

   -- Daniel

[1] 
https://git.kernel.org/cgit/linux/kernel/git/tip/tip.git/commit/?h=timers/urgent&id=03724ac3d48f8f0e3caf1d30fa134f8fd96c94e2



-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

[toc] | [prev] | [next] | [standalone]

#1309229

On Thursday 14 January 2016 10:25:40 Daniel Lezcano wrote:
> On 01/14/2016 12:02 AM, Arnd Bergmann wrote:
> > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:
> >
> > drivers/built-in.o: In function `ftm_timer_init':
> > (init.text+0xd324): undefined reference to `clocksource_mmio_init'
> > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'
> >
> > This adds the same 'select' statement that the other similar drivers
> > use. Prior to allowing this driver to be enabled with COMPILE_TEST,
> > it was apparently unused. I'm not entirely sure who is using this
> > hardware, but it certainly can't hurt to ensure it builds cleanly.
> 
> Hi Arnd,
> 
> Thanks for the fix. It is already in Thomas's tree [1].

Ok, thanks for fixing it already! I'll mark this one as superceded
in my randconfig testing git tree then and will drop it as soon as
yours is merged.

	Arnd

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web