Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO

From	Arnd Bergmann <arnd@arndb.de>
Newsgroups	linux.kernel
Subject	Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO
Date	2016-01-14 13:30 +0100
Message-ID	<qQPcm-6W6-7@gated-at.bofh.it> (permalink)
References	<qQCIa-6ET-23@gated-at.bofh.it> <qQMoa-51q-19@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thursday 14 January 2016 10:25:40 Daniel Lezcano wrote:
> On 01/14/2016 12:02 AM, Arnd Bergmann wrote:
> > The ftm clocksource driver does not build if CLKSRC_MMIO is disabled:
> >
> > drivers/built-in.o: In function `ftm_timer_init':
> > (init.text+0xd324): undefined reference to `clocksource_mmio_init'
> > (init.text+0xd484): undefined reference to `clocksource_mmio_readl_up'
> >
> > This adds the same 'select' statement that the other similar drivers
> > use. Prior to allowing this driver to be enabled with COMPILE_TEST,
> > it was apparently unused. I'm not entirely sure who is using this
> > hardware, but it certainly can't hurt to ensure it builds cleanly.
> 
> Hi Arnd,
> 
> Thanks for the fix. It is already in Thomas's tree [1].

Ok, thanks for fixing it already! I'll mark this one as superceded
in my randconfig testing git tree then and will drop it as soon as
yours is merged.

	Arnd

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] clocksource: ftm: select CLKSRC_MMIO Arnd Bergmann <arnd@arndb.de> - 2016-01-14 00:10 +0100
  Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO Daniel Lezcano <daniel.lezcano@linaro.org> - 2016-01-14 10:30 +0100
    Re: [PATCH] clocksource: ftm: select CLKSRC_MMIO Arnd Bergmann <arnd@arndb.de> - 2016-01-14 13:30 +0100

csiph-web