Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1304113 > unrolled thread

[PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

Started byWenyou Yang <wenyou.yang@atmel.com>
First post2016-01-08 03:10 +0100
Last post2016-01-12 10:00 +0100
Articles 6 — 4 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-08 03:10 +0100
    Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Rob Herring <robh@kernel.org> - 2016-01-09 16:40 +0100
      RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-12 09:10 +0100
    Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Lee Jones <lee.jones@linaro.org> - 2016-01-11 06:50 +0100
      RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-12 08:50 +0100
        Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Lee Jones <lee.jones@linaro.org> - 2016-01-12 10:00 +0100

#1304113 — [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings

FromWenyou Yang <wenyou.yang@atmel.com>
Date2016-01-08 03:10 +0100
Subject[PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
Message-ID<qOuF4-8n1-1@gated-at.bofh.it>
The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
two subdevices:
 - Regulator
 - Charger

This patch adds documentation for ACT8945A DT bindings.

Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
---

 Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
 1 file changed, 16 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt

diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
new file mode 100644
index 0000000..406db16
--- /dev/null
+++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
@@ -0,0 +1,16 @@
+Device-Tree bindings for Active-semi ACT8945A MFD driver
+
+Required properties:
+ - compatible: "active-semi,act8945a".
+ - reg: the I2C slave address for the ACT8945A chip
+
+The chip exposes two subdevices:
+ - a regulators: see ../regulator/act8945a-regulator.txt
+ - a charger: see ../power/act8945a-charger.txt
+
+Example:
+	mfd: act8945a@5b {
+		compatible = "active-semi,act8945a";
+		reg = <0x5b>;
+		status = "okay";
+	};
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1305247

FromRob Herring <robh@kernel.org>
Date2016-01-09 16:40 +0100
Message-ID<qP3Mu-7tt-29@gated-at.bofh.it>
In reply to#1304113
On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
>  - Regulator
>  - Charger
> 
> This patch adds documentation for ACT8945A DT bindings.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>

One nit, otherwise:

Acked-by: Rob Herring <robh@kernel.org>

> ---
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> +	mfd: act8945a@5b {

s/act8945a/pmic/

> +		compatible = "active-semi,act8945a";
> +		reg = <0x5b>;
> +		status = "okay";
> +	};
> -- 
> 1.7.9.5
> 
> --
> To unsubscribe from this list: send the line "unsubscribe devicetree" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

[toc] | [prev] | [next] | [standalone]

#1307074

From"Yang, Wenyou" <Wenyou.Yang@atmel.com>
Date2016-01-12 09:10 +0100
Message-ID<qQ2bE-6zh-19@gated-at.bofh.it>
In reply to#1305247
Hi Rob,

> -----Original Message-----
> From: Rob Herring [mailto:robh@kernel.org]
> Sent: 2016年1月9日 23:38
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Lee Jones <lee.jones@linaro.org>; Pawel Moll <pawel.moll@arm.com>; Mark
> Rutland <mark.rutland@arm.com>; Ian Campbell <ijc+devicetree@hellion.org.uk>;
> Kumar Gala <galak@codeaurora.org>; Ferre, Nicolas
> <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> 
> On Fri, Jan 08, 2016 at 10:05:28AM +0800, Wenyou Yang wrote:
> > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > subdevices:
> >  - Regulator
> >  - Charger
> >
> > This patch adds documentation for ACT8945A DT bindings.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> 
> One nit, otherwise:
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> > ---
> >
> >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > new file mode 100644
> > index 0000000..406db16
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > @@ -0,0 +1,16 @@
> > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > +
> > +Required properties:
> > + - compatible: "active-semi,act8945a".
> > + - reg: the I2C slave address for the ACT8945A chip
> > +
> > +The chip exposes two subdevices:
> > + - a regulators: see ../regulator/act8945a-regulator.txt
> > + - a charger: see ../power/act8945a-charger.txt
> > +
> > +Example:
> > +	mfd: act8945a@5b {
> 
> s/act8945a/pmic/

The patch is changed in the next verion, add the pmic and charger nodes.

So, I am not add your Acked-by.

> 
> > +		compatible = "active-semi,act8945a";
> > +		reg = <0x5b>;
> > +		status = "okay";
> > +	};
> > --
> > 1.7.9.5
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe devicetree"
> > in the body of a message to majordomo@vger.kernel.org More majordomo
> > info at  http://vger.kernel.org/majordomo-info.html


Best Regards,
Wenyou Yang

[toc] | [prev] | [next] | [standalone]

#1305856

FromLee Jones <lee.jones@linaro.org>
Date2016-01-11 06:50 +0100
Message-ID<qPDwD-6rd-15@gated-at.bofh.it>
In reply to#1304113
On Fri, 08 Jan 2016, Wenyou Yang wrote:

> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
>  - Regulator
>  - Charger

Is this really an MFD?  What special handling does it require?

> This patch adds documentation for ACT8945A DT bindings.
> 
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
> 
>  Documentation/devicetree/bindings/mfd/act8945a.txt |   16 ++++++++++++++++
>  1 file changed, 16 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> 
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> +	mfd: act8945a@5b {

"mfd" is too generic to be a label.

Why do you need a label in any case?

> +		compatible = "active-semi,act8945a";
> +		reg = <0x5b>;
> +		status = "okay";
> +	};

This doesn't look much like an MFD to me.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [next] | [standalone]

#1307059

From"Yang, Wenyou" <Wenyou.Yang@atmel.com>
Date2016-01-12 08:50 +0100
Message-ID<qQ1Si-6do-17@gated-at.bofh.it>
In reply to#1305856
Hi Lee,

> -----Original Message-----
> From: Lee Jones [mailto:lee.jones@linaro.org]
> Sent: 2016年1月11日 13:49
> To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>;
> Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Ferre,
> Nicolas <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> devicetree@vger.kernel.org
> Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> 
> On Fri, 08 Jan 2016, Wenyou Yang wrote:
> 
> > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > subdevices:
> >  - Regulator
> >  - Charger
> 
> Is this really an MFD?  What special handling does it require?

Yes, this is an MFD, two sub devices: regulators and charger.

> 
> > This patch adds documentation for ACT8945A DT bindings.
> >
> > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > ---
> >
> >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> ++++++++++++++++
> >  1 file changed, 16 insertions(+)
> >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> >
> > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > new file mode 100644
> > index 0000000..406db16
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > @@ -0,0 +1,16 @@
> > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > +
> > +Required properties:
> > + - compatible: "active-semi,act8945a".
> > + - reg: the I2C slave address for the ACT8945A chip
> > +
> > +The chip exposes two subdevices:
> > + - a regulators: see ../regulator/act8945a-regulator.txt
> > + - a charger: see ../power/act8945a-charger.txt
> > +
> > +Example:
> > +	mfd: act8945a@5b {
> 
> "mfd" is too generic to be a label.
> 
> Why do you need a label in any case?

Remove the mfd, use act8945a@5b.

> 
> > +		compatible = "active-semi,act8945a";
> > +		reg = <0x5b>;
> > +		status = "okay";
> > +	};
> 
> This doesn't look much like an MFD to me.

I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

> 
> --
> Lee Jones
> Linaro STMicroelectronics Landing Team Lead Linaro.org │ Open source
> software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog


Best Regards,
Wenyou Yang

[toc] | [prev] | [next] | [standalone]

#1307121

FromLee Jones <lee.jones@linaro.org>
Date2016-01-12 10:00 +0100
Message-ID<qQ2Y2-6UJ-5@gated-at.bofh.it>
In reply to#1307059
On Tue, 12 Jan 2016, Yang, Wenyou wrote:

> Hi Lee,
> 
> > -----Original Message-----
> > From: Lee Jones [mailto:lee.jones@linaro.org]
> > Sent: 2016年1月11日 13:49
> > To: Yang, Wenyou <Wenyou.Yang@atmel.com>
> > Cc: Rob Herring <robh+dt@kernel.org>; Pawel Moll <pawel.moll@arm.com>;
> > Mark Rutland <mark.rutland@arm.com>; Ian Campbell
> > <ijc+devicetree@hellion.org.uk>; Kumar Gala <galak@codeaurora.org>; Ferre,
> > Nicolas <Nicolas.FERRE@atmel.com>; linux-kernel@vger.kernel.org;
> > devicetree@vger.kernel.org
> > Subject: Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings
> > 
> > On Fri, 08 Jan 2016, Wenyou Yang wrote:
> > 
> > > The Active-semi ACT8945A PMIC is a Multi-Function Device, it has two
> > > subdevices:
> > >  - Regulator
> > >  - Charger
> > 
> > Is this really an MFD?  What special handling does it require?
> 
> Yes, this is an MFD, two sub devices: regulators and charger.
> 
> > 
> > > This patch adds documentation for ACT8945A DT bindings.
> > >
> > > Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> > > ---
> > >
> > >  Documentation/devicetree/bindings/mfd/act8945a.txt |   16
> > ++++++++++++++++
> > >  1 file changed, 16 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > new file mode 100644
> > > index 0000000..406db16
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> > > @@ -0,0 +1,16 @@
> > > +Device-Tree bindings for Active-semi ACT8945A MFD driver
> > > +
> > > +Required properties:
> > > + - compatible: "active-semi,act8945a".
> > > + - reg: the I2C slave address for the ACT8945A chip
> > > +
> > > +The chip exposes two subdevices:
> > > + - a regulators: see ../regulator/act8945a-regulator.txt
> > > + - a charger: see ../power/act8945a-charger.txt
> > > +
> > > +Example:
> > > +	mfd: act8945a@5b {
> > 
> > "mfd" is too generic to be a label.
> > 
> > Why do you need a label in any case?
> 
> Remove the mfd, use act8945a@5b.

Use pmic@5b

> > > +		compatible = "active-semi,act8945a";
> > > +		reg = <0x5b>;
> > > +		status = "okay";
> > > +	};
> > 
> > This doesn't look much like an MFD to me.
> 
> I will add the child nodes for its sub devices, inclusive pmic and charger nodes.

Very well.

-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web