Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1305856
| From | Lee Jones <lee.jones@linaro.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings |
| Date | 2016-01-11 06:50 +0100 |
| Message-ID | <qPDwD-6rd-15@gated-at.bofh.it> (permalink) |
| References | <qOuF4-8n1-3@gated-at.bofh.it> <qOuF4-8n1-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
On Fri, 08 Jan 2016, Wenyou Yang wrote:
> The Active-semi ACT8945A PMIC is a Multi-Function Device, it has
> two subdevices:
> - Regulator
> - Charger
Is this really an MFD? What special handling does it require?
> This patch adds documentation for ACT8945A DT bindings.
>
> Signed-off-by: Wenyou Yang <wenyou.yang@atmel.com>
> ---
>
> Documentation/devicetree/bindings/mfd/act8945a.txt | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/mfd/act8945a.txt
>
> diff --git a/Documentation/devicetree/bindings/mfd/act8945a.txt b/Documentation/devicetree/bindings/mfd/act8945a.txt
> new file mode 100644
> index 0000000..406db16
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mfd/act8945a.txt
> @@ -0,0 +1,16 @@
> +Device-Tree bindings for Active-semi ACT8945A MFD driver
> +
> +Required properties:
> + - compatible: "active-semi,act8945a".
> + - reg: the I2C slave address for the ACT8945A chip
> +
> +The chip exposes two subdevices:
> + - a regulators: see ../regulator/act8945a-regulator.txt
> + - a charger: see ../power/act8945a-charger.txt
> +
> +Example:
> + mfd: act8945a@5b {
"mfd" is too generic to be a label.
Why do you need a label in any case?
> + compatible = "active-semi,act8945a";
> + reg = <0x5b>;
> + status = "okay";
> + };
This doesn't look much like an MFD to me.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Wenyou Yang <wenyou.yang@atmel.com> - 2016-01-08 03:10 +0100
Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Rob Herring <robh@kernel.org> - 2016-01-09 16:40 +0100
RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-12 09:10 +0100
Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Lee Jones <lee.jones@linaro.org> - 2016-01-11 06:50 +0100
RE: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings "Yang, Wenyou" <Wenyou.Yang@atmel.com> - 2016-01-12 08:50 +0100
Re: [PATCH 2/2] mfd: add documentation for ACT8945A DT bindings Lee Jones <lee.jones@linaro.org> - 2016-01-12 10:00 +0100
csiph-web