Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305504 > unrolled thread

[PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC

Back to article view | Back to linux.kernel

Contents

  [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 08:30 +0100
    Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 11:40 +0100
      Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Heiko Stuebner <heiko@sntech.de> - 2016-01-10 19:30 +0100
    Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Heiko Stuebner <heiko@sntech.de> - 2016-01-10 11:40 +0100
      Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 11:40 +0100

#1305504 — [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC

Because the RK3036 doesn't support EMAC, and only support the RMII mode
in the EMAC IP, we refer to the TRM CRU and update the new external
clock name for EMAC.

Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
---

 .../bindings/clock/rockchip,rk3036-cru.txt         |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
index ace0599..20df350 100644
--- a/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
+++ b/Documentation/devicetree/bindings/clock/rockchip,rk3036-cru.txt
@@ -30,7 +30,7 @@ that they are defined using standard clock bindings with following
 clock-output-names:
  - "xin24m" - crystal input - required,
  - "ext_i2s" - external I2S clock - optional,
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional
 
 Example: Clock controller node:
 
-- 
1.7.9.5

[toc] | [next] | [standalone]

#1305533

Hi Heiko,

> 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> 
> 
> Hi Heiko,
> 
>> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
>> 
>> Hi Xing,
>> 
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>> 
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> 
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>> 
>> 
>> Heiko
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
> 
> OK, thank you for your help.  :)

Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional

I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional

Thanks. :)

[toc] | [prev] | [next] | [standalone]

#1305652

Am Sonntag, 10. Januar 2016, 18:36:12 schrieb Xing Zheng:
> Hi Heiko,
> 
> > 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> > 
> > 
> > Hi Heiko,
> > 
> >> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> >> 
> >> Hi Xing,
> >> 
> >> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> >>> Because the RK3036 doesn't support EMAC, and only support the RMII
> >>> mode
> >>> in the EMAC IP, we refer to the TRM CRU and update the new external
> >>> clock name for EMAC.
> >>> 
> >>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> >> 
> >> as I said in the other mail, I already fixed the original patch myself
> >> :-) So I'm just going to drop this one.
> >> 
> >> 
> >> Heiko
> >> 
> >> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/c
> >> ommit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931> 
> > I am sorry to misunderstand.
> > 
> > OK, thank you for your help.  :)
> 
> Your patch is:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external GMAC clock - optional
> 
> I think that these should be like this:
> - - "ext_gmac" - external GMAC clock - optional
> + - "rmii_clkin" - external EMAC clock - optional

I fixed that up now, thanks for catching this.

https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=1c888eb1054a08620a8d2bc5dd2d7cc290897371


Heiko

[toc] | [prev] | [next] | [standalone]

#1305535

Hi Xing,

Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
> Because the RK3036 doesn't support EMAC, and only support the RMII mode
> in the EMAC IP, we refer to the TRM CRU and update the new external
> clock name for EMAC.
> 
> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>

as I said in the other mail, I already fixed the original patch myself :-)
So I'm just going to drop this one.


Heiko

https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931

[toc] | [prev] | [next] | [standalone]

#1305538

Hi Heiko,

> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
> 
> Hi Xing,
> 
> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>> in the EMAC IP, we refer to the TRM CRU and update the new external
>> clock name for EMAC.
>> 
>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
> 
> as I said in the other mail, I already fixed the original patch myself :-)
> So I'm just going to drop this one.
> 
> 
> Heiko
> 
> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> 
I am sorry to misunderstand.

OK, thank you for your help.  :)

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web