Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1305533

Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC

From Xing Zheng <zhengxing@rock-chips.com>
Newsgroups linux.kernel
Subject Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC
Date 2016-01-10 11:40 +0100
Message-ID <qPlzI-2US-13@gated-at.bofh.it> (permalink)
References <qPiBP-14T-1@gated-at.bofh.it> <qPlzI-2US-15@gated-at.bofh.it> <qPlzI-2US-17@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

Hi Heiko,

> 在 2016年1月10日，18:29，Xing Zheng <zhengxing@rock-chips.com> 写道：
> 
> 
> Hi Heiko,
> 
>> 在 2016年1月10日，17:59，Heiko Stuebner <heiko@sntech.de> 写道：
>> 
>> Hi Xing,
>> 
>> Am Sonntag, 10. Januar 2016, 15:22:37 schrieb Xing Zheng:
>>> Because the RK3036 doesn't support EMAC, and only support the RMII mode
>>> in the EMAC IP, we refer to the TRM CRU and update the new external
>>> clock name for EMAC.
>>> 
>>> Signed-off-by: Xing Zheng <zhengxing@rock-chips.com>
>> 
>> as I said in the other mail, I already fixed the original patch myself :-)
>> So I'm just going to drop this one.
>> 
>> 
>> Heiko
>> 
>> https://git.kernel.org/cgit/linux/kernel/git/mmind/linux-rockchip.git/commit/?h=v4.5-clk/fixes&id=88807906af108a8384d77ad9cfb9421f164ea931
> I am sorry to misunderstand.
> 
> OK, thank you for your help.  :)

Your patch is:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external GMAC clock - optional

I think that these should be like this:
- - "ext_gmac" - external GMAC clock - optional
+ - "rmii_clkin" - external EMAC clock - optional

Thanks. :)

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 08:30 +0100
  Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 11:40 +0100
    Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Heiko Stuebner <heiko@sntech.de> - 2016-01-10 19:30 +0100
  Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Heiko Stuebner <heiko@sntech.de> - 2016-01-10 11:40 +0100
    Re: [PATCH] dt-bindings: Fix the external clock name for the RK3036 EMAC Xing Zheng <zhengxing@rock-chips.com> - 2016-01-10 11:40 +0100

csiph-web