Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1303996 > unrolled thread
| Started by | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| First post | 2016-01-08 00:20 +0100 |
| Last post | 2016-01-08 01:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Andrew Morton <akpm@linux-foundation.org> - 2016-01-08 00:20 +0100
Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Mike Kravetz <mike.kravetz@oracle.com> - 2016-01-08 01:00 +0100
| From | Andrew Morton <akpm@linux-foundation.org> |
|---|---|
| Date | 2016-01-08 00:20 +0100 |
| Subject | Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list |
| Message-ID | <qOs0y-6yc-23@gated-at.bofh.it> |
On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote: > Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine. > The argument end is of type pgoff_t. It was being converted to a > vaddr offset and passed to unmap_hugepage_range. However, end > was also being used as an argument to the vma_interval_tree_foreach > controlling loop. In addition, the conversion of end to vaddr offset > was incorrect. Could we please have a description of the user-visible effects of the bug? It's always needed for -stable things. And for all bugfixes, really. (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)
[toc] | [next] | [standalone]
| From | Mike Kravetz <mike.kravetz@oracle.com> |
|---|---|
| Date | 2016-01-08 01:00 +0100 |
| Message-ID | <qOsDh-6P8-23@gated-at.bofh.it> |
| In reply to | #1303996 |
On 01/07/2016 03:13 PM, Andrew Morton wrote: > On Thu, 7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote: > >> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine. >> The argument end is of type pgoff_t. It was being converted to a >> vaddr offset and passed to unmap_hugepage_range. However, end >> was also being used as an argument to the vma_interval_tree_foreach >> controlling loop. In addition, the conversion of end to vaddr offset >> was incorrect. > > Could we please have a description of the user-visible effects of the > bug? It's always needed for -stable things. And for all bugfixes, really. > > (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed) Will do. As I stare at the code to come up with user visible effects, I am not convinced the fix is correct. An update will come after more study. -- Mike Kravetz
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web