Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list

From	Mike Kravetz <mike.kravetz@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list
Date	2016-01-08 01:00 +0100
Message-ID	<qOsDh-6P8-23@gated-at.bofh.it> (permalink)
References	<qOs0y-6yc-25@gated-at.bofh.it> <qOs0y-6yc-23@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 01/07/2016 03:13 PM, Andrew Morton wrote:
> On Thu,  7 Jan 2016 14:35:37 -0800 Mike Kravetz <mike.kravetz@oracle.com> wrote:
> 
>> Hillf Danton noticed bugs in the hugetlb_vmtruncate_list routine.
>> The argument end is of type pgoff_t.  It was being converted to a
>> vaddr offset and passed to unmap_hugepage_range.  However, end
>> was also being used as an argument to the vma_interval_tree_foreach
>> controlling loop.  In addition, the conversion of end to vaddr offset
>> was incorrect.
> 
> Could we please have a description of the user-visible effects of the
> bug?  It's always needed for -stable things.  And for all bugfixes, really.
> 
> (stable@vger.kernel.org[4.3] isn't an email address btw - my client barfed)

Will do.

As I stare at the code to come up with user visible effects, I am not
convinced the fix is correct.  An update will come after more study.

-- 
Mike Kravetz

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Andrew Morton <akpm@linux-foundation.org> - 2016-01-08 00:20 +0100
  Re: [PATCH] mm/hugetlbfs Fix bugs in hugetlb_vmtruncate_list Mike Kravetz <mike.kravetz@oracle.com> - 2016-01-08 01:00 +0100

csiph-web