Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1302878 > unrolled thread

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-06 17:30 +0100
    Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-06 18:40 +0100
      Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-07 10:40 +0100
        Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-07 19:40 +0100
          Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-08 10:00 +0100
            Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-08 12:00 +0100

#1302878 — Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> 
>> > On Mon, 2015-12-21 at 19:27 +0000, Måns Rullgård wrote:
>> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> > > 
>> > > > I can share my working branch with a set of patches regarding
>> > > > to dw_dmac. We may do our work based on that code and after
>> > > > I'll submit everything to upstream. Does it sound okay for you,
>> > > > guys?
>> > > 
>> > > I'm going away for the holidays, so I won't be able to do any
>> > > serious work on this until January, but I'll keep an eye on
>> > > emails and may even reply occasionally.  Before I go, I'll
>> > > publish my patches so far whatever shape they're in.
>> > 
>> > Okay, thanks! I will include them in my branch which I'm going to
>> > publish on GitHUB.
>> 
>> Here's what I have: https://bitbucket.org/mansr/linux-dwc
>> Bitbucket because Github won't let me have more than one Linux
>> repo.
>
> Thanks, got it.
>
> Will base my stuff on what you had done already.

I've revived my AVR32 board, and after patching up some unrelated
regressions, the MMC controller is working with the DMA driver as
of 4.4-rc8 as well as with my patches applied.

-- 
Måns Rullgård
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1302922 — Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård <mans@mansr.com> wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>
>> On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
>>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>>>
>>> > On Mon, 2015-12-21 at 19:27 +0000, Måns Rullgård wrote:
>>> > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>>> > >
>>> > > > I can share my working branch with a set of patches regarding
>>> > > > to dw_dmac. We may do our work based on that code and after
>>> > > > I'll submit everything to upstream. Does it sound okay for you,
>>> > > > guys?
>>> > >
>>> > > I'm going away for the holidays, so I won't be able to do any
>>> > > serious work on this until January, but I'll keep an eye on
>>> > > emails and may even reply occasionally.  Before I go, I'll
>>> > > publish my patches so far whatever shape they're in.
>>> >
>>> > Okay, thanks! I will include them in my branch which I'm going to
>>> > publish on GitHUB.
>>>
>>> Here's what I have: https://bitbucket.org/mansr/linux-dwc
>>> Bitbucket because Github won't let me have more than one Linux
>>> repo.
>>
>> Thanks, got it.
>>
>> Will base my stuff on what you had done already.
>
> I've revived my AVR32 board, and after patching up some unrelated
> regressions, the MMC controller is working with the DMA driver as
> of 4.4-rc8 as well as with my patches applied.

I'm going to publish my branch tomorrow. It has been tested a bit on
Intel hw, and works fine (yours patches are included with some slight
changes)

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1303418 — Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
> On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård <mans@mansr.com> wrote:
> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > 
> > > On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> > > > 
> > > > > Here's what I have: https://bitbucket.org/mansr/linux-dwc
> > > > Bitbucket because Github won't let me have more than one Linux
> > > > repo.
> > > 
> > > Thanks, got it.
> > > 
> > > Will base my stuff on what you had done already.
> > 
> > I've revived my AVR32 board, and after patching up some unrelated
> > regressions, the MMC controller is working with the DMA driver as
> > of 4.4-rc8 as well as with my patches applied.
> 
> I'm going to publish my branch tomorrow. It has been tested a bit on
> Intel hw, and works fine (yours patches are included with some slight
> changes)

So, Måns, Julian, I just have published my repository containing Måns'
and my patches regarding dw_dmac and sata_dwc_460ex drivers here

https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1303796

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
>> On Wed, Jan 6, 2016 at 6:26 PM, Måns Rullgård <mans@mansr.com> wrote:
>> > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> > 
>> > > On Tue, 2015-12-22 at 00:08 +0000, Måns Rullgård wrote:
>> > > > Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> > > > 
>> > > > > Here's what I have: https://bitbucket.org/mansr/linux-dwc
>> > > > Bitbucket because Github won't let me have more than one Linux
>> > > > repo.
>> > > 
>> > > Thanks, got it.
>> > > 
>> > > Will base my stuff on what you had done already.
>> > 
>> > I've revived my AVR32 board, and after patching up some unrelated
>> > regressions, the MMC controller is working with the DMA driver as
>> > of 4.4-rc8 as well as with my patches applied.
>> 
>> I'm going to publish my branch tomorrow. It has been tested a bit on
>> Intel hw, and works fine (yours patches are included with some slight
>> changes)
>
> So, Måns, Julian, I just have published my repository containing Måns'
> and my patches regarding dw_dmac and sata_dwc_460ex drivers here
>
> https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext

I've picked out the relevant changes from your branch and made some
additional improvements.  A few notes:

- The __be32/__le32 typedefs for the DMA descriptor fields are necessary
  to avoid a million sparse warnings (and sparse is correct to warn).
- Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver may
  well be used on another big endian system some day.  The Kconfig logic
  for selecting this option could perhaps be improved though.

Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver).

Code here:
https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata

-- 
Måns Rullgård

[toc] | [prev] | [next] | [standalone]

#1304283 — Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote:

> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
> 
> > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
> > > 
> > So, Måns, Julian, I just have published my repository containing
> > Måns'
> > and my patches regarding dw_dmac and sata_dwc_460ex drivers here
> > 
> > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext
> 
> I've picked out the relevant changes from your branch and made some
> additional improvements.  A few notes:
> 
> - The __be32/__le32 typedefs for the DMA descriptor fields are
> necessary
>   to avoid a million sparse warnings (and sparse is correct to warn).

Hmm… Which version of sparse are you using? I always run builds with
sparse enabled and didn't see anything.

> - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver
> may
>   well be used on another big endian system some day.  The Kconfig
> logic
>   for selecting this option could perhaps be improved though.

Maybe runtime chosen accessors will be better than ifdefs?
I don't like the Kconfig option which limits application of the
(compiled) driver.

> 
> Tested on AVR32 (DMA driver) and Sigma SMP8642 (SATA driver).
> 
> Code here:
> https://bitbucket.org/mansr/linux-dwc/branch/dwc-sata

Thanks for testing!

-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

[toc] | [prev] | [next] | [standalone]

#1304370

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote:
>
>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> 
>> > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
>> > > 
>> > So, Måns, Julian, I just have published my repository containing
>> > Måns' and my patches regarding dw_dmac and sata_dwc_460ex drivers
>> > here
>> > 
>> > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext
>> 
>> I've picked out the relevant changes from your branch and made some
>> additional improvements.  A few notes:
>> 
>> - The __be32/__le32 typedefs for the DMA descriptor fields are necessary
>>   to avoid a million sparse warnings (and sparse is correct to warn).
>
> Hmm… Which version of sparse are you using? I always run builds with
> sparse enabled and didn't see anything.

You need to enable endian checking with CF=-D__CHECK_ENDIAN__

>> - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver may
>>   well be used on another big endian system some day.  The Kconfig logic
>>   for selecting this option could perhaps be improved though.
>
> Maybe runtime chosen accessors will be better than ifdefs?

Are there any systems that could otherwise run the same kernel that use
this hardware with different byte order?  I doubt it.

> I don't like the Kconfig option which limits application of the
> (compiled) driver.

It's no more limited than a hard #ifdef AVR32 in the driver code.

-- 
Måns Rullgård

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web