Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel

From	Måns Rullgård <mans@mansr.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel
Date	2016-01-08 12:00 +0100
Message-ID	<qOCVX-5yb-5@gated-at.bofh.it> (permalink)
References	(16 earlier) <qNZ8e-3yE-15@gated-at.bofh.it> <qO0dZ-4eZ-21@gated-at.bofh.it> <qOfd0-6ef-7@gated-at.bofh.it> <qOnDA-3xV-21@gated-at.bofh.it> <qOB3Q-4hQ-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote:
>
>> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:
>> 
>> > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote:
>> > > 
>> > So, Måns, Julian, I just have published my repository containing
>> > Måns' and my patches regarding dw_dmac and sata_dwc_460ex drivers
>> > here
>> > 
>> > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext
>> 
>> I've picked out the relevant changes from your branch and made some
>> additional improvements.  A few notes:
>> 
>> - The __be32/__le32 typedefs for the DMA descriptor fields are necessary
>>   to avoid a million sparse warnings (and sparse is correct to warn).
>
> Hmm… Which version of sparse are you using? I always run builds with
> sparse enabled and didn't see anything.

You need to enable endian checking with CF=-D__CHECK_ENDIAN__

>> - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver may
>>   well be used on another big endian system some day.  The Kconfig logic
>>   for selecting this option could perhaps be improved though.
>
> Maybe runtime chosen accessors will be better than ifdefs?

Are there any systems that could otherwise run the same kernel that use
this hardware with different byte order?  I doubt it.

> I don't like the Kconfig option which limits application of the
> (compiled) driver.

It's no more limited than a hard #ifdef AVR32 in the driver code.

-- 
Måns Rullgård

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-06 17:30 +0100
  Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andy.shevchenko@gmail.com> - 2016-01-06 18:40 +0100
    Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-07 10:40 +0100
      Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-07 19:40 +0100
        Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find  dma channel Andy Shevchenko <andriy.shevchenko@linux.intel.com> - 2016-01-08 10:00 +0100
          Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel Måns Rullgård <mans@mansr.com> - 2016-01-08 12:00 +0100

csiph-web