Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300427 > unrolled thread
| Started by | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| First post | 2016-01-04 02:30 +0100 |
| Last post | 2016-01-09 10:50 +0100 |
| Articles | 3 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Namhyung Kim <namhyung@kernel.org> - 2016-01-04 02:30 +0100
Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Marcin Ślusarz <marcin.slusarz@gmail.com> - 2016-01-08 00:20 +0100
Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps Namhyung Kim <namhyung@kernel.org> - 2016-01-09 10:50 +0100
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2016-01-04 02:30 +0100 |
| Subject | Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps |
| Message-ID | <qN28a-4OO-13@gated-at.bofh.it> |
Hi Marcin,
On Fri, Jan 01, 2016 at 04:03:21AM +0100, Marcin Ślusarz wrote:
> Steam frequently puts game binaries in folders with spaces.
>
> Note: "(deleted)" markers are now treated as part of the file name.
>
> It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> ("perf tools: Use sscanf for parsing /proc/pid/maps").
>
> Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
> tools/perf/util/event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 8b10621..ff17fe6 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> strcpy(execname, "");
>
> /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
> - n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]s\n",
Is the last 's' necessary?
Thanks,
Namhyung
> &event->mmap2.start, &event->mmap2.len, prot,
> &event->mmap2.pgoff, &event->mmap2.maj,
> &event->mmap2.min,
> --
> 2.1.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Marcin Ślusarz <marcin.slusarz@gmail.com> |
|---|---|
| Date | 2016-01-08 00:20 +0100 |
| Message-ID | <qOs0x-6yc-11@gated-at.bofh.it> |
| In reply to | #1300427 |
On Mon, Jan 04, 2016 at 10:25:28AM +0900, Namhyung Kim wrote:
> Hi Marcin,
>
> On Fri, Jan 01, 2016 at 04:03:21AM +0100, Marcin Ślusarz wrote:
> > Steam frequently puts game binaries in folders with spaces.
> >
> > Note: "(deleted)" markers are now treated as part of the file name.
> >
> > It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> > ("perf tools: Use sscanf for parsing /proc/pid/maps").
> >
> > Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> > Cc: Namhyung Kim <namhyung@kernel.org>
> > Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> > ---
> > tools/perf/util/event.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> > index 8b10621..ff17fe6 100644
> > --- a/tools/perf/util/event.c
> > +++ b/tools/perf/util/event.c
> > @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> > strcpy(execname, "");
> >
> > /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
> > - n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> > + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]s\n",
>
> Is the last 's' necessary?
Nope. It should not be there.
---
From: Marcin Ślusarz <marcin.slusarz@gmail.com>
Subject: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps
Steam frequently puts game binaries in folders with spaces.
Note: "(deleted)" markers are now treated as part of the file name.
It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
("perf tools: Use sscanf for parsing /proc/pid/maps").
Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
---
tools/perf/util/event.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 8b10621..956187b 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
strcpy(execname, "");
/* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
- n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
+ n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
&event->mmap2.start, &event->mmap2.len, prot,
&event->mmap2.pgoff, &event->mmap2.maj,
&event->mmap2.min,
--
2.1.4
[toc] | [prev] | [next] | [standalone]
| From | Namhyung Kim <namhyung@kernel.org> |
|---|---|
| Date | 2016-01-09 10:50 +0100 |
| Message-ID | <qOYjM-3Du-3@gated-at.bofh.it> |
| In reply to | #1303994 |
> From: Marcin Ślusarz <marcin.slusarz@gmail.com>
> Subject: [PATCH v2] perf tools: handle spaces in file names obtained from /proc/pid/maps
>
> Steam frequently puts game binaries in folders with spaces.
>
> Note: "(deleted)" markers are now treated as part of the file name.
>
> It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> ("perf tools: Use sscanf for parsing /proc/pid/maps").
>
> Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Acked-by: Namhyung Kim <namhyung@kernel.org>
Thanks,
Namhyung
> ---
> tools/perf/util/event.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 8b10621..956187b 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
> strcpy(execname, "");
>
> /* 00400000-0040c000 r-xp 00000000 fd:01 41038 /bin/cat */
> - n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> + n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]\n",
> &event->mmap2.start, &event->mmap2.len, prot,
> &event->mmap2.pgoff, &event->mmap2.maj,
> &event->mmap2.min,
> --
> 2.1.4
>
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web