Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300427

Re: [PATCH] perf tools: handle spaces in file names obtained from /proc/pid/maps

Show all headers | View raw

Hi Marcin,

On Fri, Jan 01, 2016 at 04:03:21AM +0100, Marcin Ślusarz wrote:
> Steam frequently puts game binaries in folders with spaces.
> 
> Note: "(deleted)" markers are now treated as part of the file name.
> 
> It probably worked before 6064803313bad9ae4cae233a9d56678adb2b6e7c
> ("perf tools: Use sscanf for parsing /proc/pid/maps").
> 
> Signed-off-by: Marcin Ślusarz <marcin.slusarz@gmail.com>
> Cc: Namhyung Kim <namhyung@kernel.org>
> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
> ---
>  tools/perf/util/event.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
> index 8b10621..ff17fe6 100644
> --- a/tools/perf/util/event.c
> +++ b/tools/perf/util/event.c
> @@ -274,7 +274,7 @@ int perf_event__synthesize_mmap_events(struct perf_tool *tool,
>  		strcpy(execname, "");
>  
>  		/* 00400000-0040c000 r-xp 00000000 fd:01 41038  /bin/cat */
> -		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %s\n",
> +		n = sscanf(bf, "%"PRIx64"-%"PRIx64" %s %"PRIx64" %x:%x %u %[^\n]s\n",

Is the last 's' necessary?

Thanks,
Namhyung


>  		       &event->mmap2.start, &event->mmap2.len, prot,
>  		       &event->mmap2.pgoff, &event->mmap2.maj,
>  		       &event->mmap2.min,
> -- 
> 2.1.4
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] perf tools: handle spaces in file names obtained from  /proc/pid/maps Marcin Ślusarz <marcin.slusarz@gmail.com> - 2016-01-01 04:10 +0100
  Re: [PATCH] perf tools: handle spaces in file names obtained from  /proc/pid/maps Namhyung Kim <namhyung@kernel.org> - 2016-01-04 02:30 +0100
    Re: [PATCH] perf tools: handle spaces in file names obtained from  /proc/pid/maps Marcin Ślusarz <marcin.slusarz@gmail.com> - 2016-01-08 00:20 +0100
      Re: [PATCH] perf tools: handle spaces in file names obtained from  /proc/pid/maps Namhyung Kim <namhyung@kernel.org> - 2016-01-09 10:50 +0100

csiph-web