Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1303240 > unrolled thread

[PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver

Started byKrzysztof Kozlowski <k.kozlowski@samsung.com>
First post2016-01-07 03:20 +0100
Last post2016-01-11 17:10 +0100
Articles 5 — 3 participants

Back to article view | Back to linux.kernel

This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by below is the oldest one visible, not the original post.

Contents

  [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-07 03:20 +0100
    Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Anand Moon <linux.amoon@gmail.com> - 2016-01-07 18:20 +0100
    Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 16:40 +0100
      Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-09 03:50 +0100
        Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:10 +0100

#1303240 — [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-01-07 03:20 +0100
Subject[PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
Message-ID<qO8lb-1pd-1@gated-at.bofh.it>
The Exynos SoC provides a Security SubSystem block for accelerating some
cryptographic operations. Enable the driver for it - s5p-secss to
utilize the hardware acceleration.

Currently the s5p-secss driver supports AES in CBC and ECB modes.
However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
change introduces one booting error:

	alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22

The cbc-aes-s5p properly registers itself and passes self-tests.

Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
---
 arch/arm/configs/exynos_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
index 0aee1e035be9..c47c7e069873 100644
--- a/arch/arm/configs/exynos_defconfig
+++ b/arch/arm/configs/exynos_defconfig
@@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
 CONFIG_DEBUG_SPINLOCK=y
 CONFIG_DEBUG_MUTEXES=y
 CONFIG_DEBUG_USER=y
+CONFIG_CRYPTO_DEV_S5P=y
 CONFIG_ARM_CRYPTO=y
 CONFIG_CRYPTO_SHA1_ARM_NEON=m
 CONFIG_CRYPTO_SHA256_ARM=m
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [next] | [standalone]

#1303743

FromAnand Moon <linux.amoon@gmail.com>
Date2016-01-07 18:20 +0100
Message-ID<qOmoa-2Kl-15@gated-at.bofh.it>
In reply to#1303240
Hi Krzysztof,

On 7 January 2016 at 07:45, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
>
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
>
>         alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>
> The cbc-aes-s5p properly registers itself and passes self-tests.
>
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>  CONFIG_DEBUG_SPINLOCK=y
>  CONFIG_DEBUG_MUTEXES=y
>  CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y
>  CONFIG_ARM_CRYPTO=y
>  CONFIG_CRYPTO_SHA1_ARM_NEON=m
>  CONFIG_CRYPTO_SHA256_ARM=m
> --
> 1.9.1
>

Reviewed-by: Anand Moon <linux.amoon@gmail.com>

Best Regards,
-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

[toc] | [prev] | [next] | [standalone]

#1304661

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-01-08 16:40 +0100
Message-ID<qOHiW-cO-23@gated-at.bofh.it>
In reply to#1303240
Hello Krzysztof,

On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
> 
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
> 
> 	alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
> 
> The cbc-aes-s5p properly registers itself and passes self-tests.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>  CONFIG_DEBUG_SPINLOCK=y
>  CONFIG_DEBUG_MUTEXES=y
>  CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y

I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?

>  CONFIG_ARM_CRYPTO=y
>  CONFIG_CRYPTO_SHA1_ARM_NEON=m
>  CONFIG_CRYPTO_SHA256_ARM=m
> 

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [next] | [standalone]

#1305148

FromKrzysztof Kozlowski <k.kozlowski@samsung.com>
Date2016-01-09 03:50 +0100
Message-ID<qORLj-7o6-11@gated-at.bofh.it>
In reply to#1304661
2016-01-09 0:35 GMT+09:00 Javier Martinez Canillas <javier@osg.samsung.com>:
> Hello Krzysztof,
>
> On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
>> The Exynos SoC provides a Security SubSystem block for accelerating some
>> cryptographic operations. Enable the driver for it - s5p-secss to
>> utilize the hardware acceleration.
>>
>> Currently the s5p-secss driver supports AES in CBC and ECB modes.
>> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
>> change introduces one booting error:
>>
>>       alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
>>
>> The cbc-aes-s5p properly registers itself and passes self-tests.
>>
>> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> ---
>>  arch/arm/configs/exynos_defconfig | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
>> index 0aee1e035be9..c47c7e069873 100644
>> --- a/arch/arm/configs/exynos_defconfig
>> +++ b/arch/arm/configs/exynos_defconfig
>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>>  CONFIG_DEBUG_SPINLOCK=y
>>  CONFIG_DEBUG_MUTEXES=y
>>  CONFIG_DEBUG_USER=y
>> +CONFIG_CRYPTO_DEV_S5P=y
>
> I noticed that this is not enabled in multi_v7_defconfig.
> Are you planing to do it as well?

Thanks for feedback and review. I noticed that as well but I am not
convinced because one of two of supported algorithms fails the
tests... which makes 50% of driver non-working. :) Maybe it is
harmless - just pollutes the dmesg... Maybe after fixing it.

Best regards,
Krzysztof

[toc] | [prev] | [next] | [standalone]

#1306453

FromJavier Martinez Canillas <javier@osg.samsung.com>
Date2016-01-11 17:10 +0100
Message-ID<qPNcC-4IN-33@gated-at.bofh.it>
In reply to#1305148
Hello Krzysztof,

On 01/08/2016 11:46 PM, Krzysztof Kozlowski wrote:

[snip]

>>> --- a/arch/arm/configs/exynos_defconfig
>>> +++ b/arch/arm/configs/exynos_defconfig
>>> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>>>  CONFIG_DEBUG_SPINLOCK=y
>>>  CONFIG_DEBUG_MUTEXES=y
>>>  CONFIG_DEBUG_USER=y
>>> +CONFIG_CRYPTO_DEV_S5P=y
>>
>> I noticed that this is not enabled in multi_v7_defconfig.
>> Are you planing to do it as well?
> 
> Thanks for feedback and review. I noticed that as well but I am not
> convinced because one of two of supported algorithms fails the
> tests... which makes 50% of driver non-working. :) Maybe it is
> harmless - just pollutes the dmesg... Maybe after fixing it.
>

Agreed that can be done after fixing the driver.
 
> Best regards,
> Krzysztof

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

[toc] | [prev] | [standalone]

Back to top | Article view | linux.kernel

csiph-web