Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1304661

Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver

From Javier Martinez Canillas <javier@osg.samsung.com>
Newsgroups linux.kernel
Subject Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver
Date 2016-01-08 16:40 +0100
Message-ID <qOHiW-cO-23@gated-at.bofh.it> (permalink)
References <qO8lb-1pd-3@gated-at.bofh.it> <qO8lb-1pd-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


Hello Krzysztof,

On 01/06/2016 11:15 PM, Krzysztof Kozlowski wrote:
> The Exynos SoC provides a Security SubSystem block for accelerating some
> cryptographic operations. Enable the driver for it - s5p-secss to
> utilize the hardware acceleration.
> 
> Currently the s5p-secss driver supports AES in CBC and ECB modes.
> However on Odroid XU4 (Exynos5422) and Trats2 (Exynos4412) boards this
> change introduces one booting error:
> 
> 	alg: skcipher: encryption failed on chunk test 1 for ecb-aes-s5p: ret=22
> 
> The cbc-aes-s5p properly registers itself and passes self-tests.
> 
> Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> ---
>  arch/arm/configs/exynos_defconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/configs/exynos_defconfig b/arch/arm/configs/exynos_defconfig
> index 0aee1e035be9..c47c7e069873 100644
> --- a/arch/arm/configs/exynos_defconfig
> +++ b/arch/arm/configs/exynos_defconfig
> @@ -240,6 +240,7 @@ CONFIG_DEBUG_RT_MUTEXES=y
>  CONFIG_DEBUG_SPINLOCK=y
>  CONFIG_DEBUG_MUTEXES=y
>  CONFIG_DEBUG_USER=y
> +CONFIG_CRYPTO_DEV_S5P=y

I noticed that this is not enabled in multi_v7_defconfig.
Are you planing to do it as well?

>  CONFIG_ARM_CRYPTO=y
>  CONFIG_CRYPTO_SHA1_ARM_NEON=m
>  CONFIG_CRYPTO_SHA256_ARM=m
> 

Reviewed-by: Javier Martinez Canillas <javier@osg.samsung.com>

Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-07 03:20 +0100
  Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Anand Moon <linux.amoon@gmail.com> - 2016-01-07 18:20 +0100
  Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-08 16:40 +0100
    Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Krzysztof Kozlowski <k.kozlowski@samsung.com> - 2016-01-09 03:50 +0100
      Re: [PATCH 2/2] ARM: exynos_defconfig: Enable s5p-secss driver Javier Martinez Canillas <javier@osg.samsung.com> - 2016-01-11 17:10 +0100

csiph-web