Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1300638 > unrolled thread
| Started by | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| First post | 2016-01-04 12:30 +0100 |
| Last post | 2016-01-04 15:30 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory David Vrabel <david.vrabel@citrix.com> - 2016-01-04 12:30 +0100
Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-04 15:30 +0100
| From | David Vrabel <david.vrabel@citrix.com> |
|---|---|
| Date | 2016-01-04 12:30 +0100 |
| Subject | Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory |
| Message-ID | <qNbuN-2MN-1@gated-at.bofh.it> |
On 22/12/15 16:32, Vitaly Kuznetsov wrote: > @@ -1292,6 +1304,11 @@ int __ref add_memory_resource(int nid, struct resource *res) > /* create new memmap entry */ > firmware_map_add_hotplug(start, start + size, "System RAM"); > > + /* online pages if requested */ > + if (online) > + online_pages(start >> PAGE_SHIFT, size >> PAGE_SHIFT, > + MMOP_ONLINE_KEEP); This will cause the Xen balloon driver to deadlock because it calls add_memory_resource() with the balloon_mutex locked and the online page callback also locks the balloon_mutex. David -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [next] | [standalone]
| From | Vitaly Kuznetsov <vkuznets@redhat.com> |
|---|---|
| Date | 2016-01-04 15:30 +0100 |
| Subject | Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory |
| Message-ID | <qNej0-4AS-17@gated-at.bofh.it> |
| In reply to | #1300638 |
David Vrabel <david.vrabel@citrix.com> writes: > On 22/12/15 16:32, Vitaly Kuznetsov wrote: >> @@ -1292,6 +1304,11 @@ int __ref add_memory_resource(int nid, struct resource *res) >> /* create new memmap entry */ >> firmware_map_add_hotplug(start, start + size, "System RAM"); >> >> + /* online pages if requested */ >> + if (online) >> + online_pages(start >> PAGE_SHIFT, size >> PAGE_SHIFT, >> + MMOP_ONLINE_KEEP); > > This will cause the Xen balloon driver to deadlock because it calls > add_memory_resource() with the balloon_mutex locked and the online page > callback also locks the balloon_mutex. Currently xen ballon driver always calls add_memory_resource() with online=false so this won't happen. -- Vitaly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web