Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1300776

Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory

Show all headers | View raw

David Vrabel <david.vrabel@citrix.com> writes:

> On 22/12/15 16:32, Vitaly Kuznetsov wrote:
>> @@ -1292,6 +1304,11 @@ int __ref add_memory_resource(int nid, struct resource *res)
>>  	/* create new memmap entry */
>>  	firmware_map_add_hotplug(start, start + size, "System RAM");
>>  
>> +	/* online pages if requested */
>> +	if (online)
>> +		online_pages(start >> PAGE_SHIFT, size >> PAGE_SHIFT,
>> +			     MMOP_ONLINE_KEEP);
>
> This will cause the Xen balloon driver to deadlock because it calls
> add_memory_resource() with the balloon_mutex locked and the online page
> callback also locks the balloon_mutex.

Currently xen ballon driver always calls add_memory_resource() with
online=false so this won't happen.

-- 
  Vitaly
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2] memory-hotplug: add automatic onlining policy for  the newly added memory David Vrabel <david.vrabel@citrix.com> - 2016-01-04 12:30 +0100
  Re: [PATCH v2] memory-hotplug: add automatic onlining policy for the newly added memory Vitaly Kuznetsov <vkuznets@redhat.com> - 2016-01-04 15:30 +0100

csiph-web