Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1301756 > unrolled thread
| Started by | Mark Brown <broonie@kernel.org> |
|---|---|
| First post | 2016-01-05 18:50 +0100 |
| Last post | 2016-01-06 07:00 +0100 |
| Articles | 2 — 2 participants |
Back to article view | Back to linux.kernel
This discussion starts older than the indexed window; earlier articles aren't shown. The article labeled Started by
below is the oldest one visible, not the original post.
Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type Mark Brown <broonie@kernel.org> - 2016-01-05 18:50 +0100
Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-06 07:00 +0100
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Date | 2016-01-05 18:50 +0100 |
| Subject | Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type |
| Message-ID | <qNDU7-65D-43@gated-at.bofh.it> |
[Multipart message — attachments visible in raw view] — view raw
On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote: > + d->type_reg_stride = chip->type_reg_stride ? : 1; > + Please don't abuse the ternery operator, especially not the GCC extension - that's much less clear than just writing the if statement.
[toc] | [next] | [standalone]
| From | Laxman Dewangan <ldewangan@nvidia.com> |
|---|---|
| Date | 2016-01-06 07:00 +0100 |
| Subject | Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type |
| Message-ID | <qNPix-5pe-1@gated-at.bofh.it> |
| In reply to | #1301756 |
On Tuesday 05 January 2016 11:11 PM, Mark Brown wrote: > * PGP Signed by an unknown key > > On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote: > >> + d->type_reg_stride = chip->type_reg_stride ? : 1; >> + > Please don't abuse the ternery operator, especially not the GCC > extension - that's much less clear than just writing the if statement. > Sure, I will not use this in my future coding. Thanks for correcting this before applying. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
[toc] | [prev] | [standalone]
Back to top | Article view | linux.kernel
csiph-web