Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1302407

Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type

From Laxman Dewangan <ldewangan@nvidia.com>
Newsgroups linux.kernel
Subject Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger type
Date 2016-01-06 07:00 +0100
Message-ID <qNPix-5pe-1@gated-at.bofh.it> (permalink)
References <qIuRs-4nK-5@gated-at.bofh.it> <qNDU7-65D-43@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tuesday 05 January 2016 11:11 PM, Mark Brown wrote:
> * PGP Signed by an unknown key
>
> On Tue, Dec 22, 2015 at 06:25:26PM +0530, Laxman Dewangan wrote:
>
>> +	d->type_reg_stride = chip->type_reg_stride ? : 1;
>> +
> Please don't abuse the ternery operator, especially not the GCC
> extension - that's much less clear than just writing the if statement.
>

Sure, I will not use this in my future coding.
Thanks for correcting this before applying.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Back to linux.kernel | Previous | NextPrevious in thread | Find similar | Unroll thread


Thread

Re: [PATCH 1/2] regmap: irq: add support for configuration of  trigger type Mark Brown <broonie@kernel.org> - 2016-01-05 18:50 +0100
  Re: [PATCH 1/2] regmap: irq: add support for configuration of trigger  type Laxman Dewangan <ldewangan@nvidia.com> - 2016-01-06 07:00 +0100

csiph-web